【Hackathon 5th No.37】为 Paddle 新增 householder_product API -part #58214

cocoshe · 2023-10-18T19:28:33Z

PR types

New features

PR changes

APIs

Description

RFC：

文档：

【Hackathon 5th No.37】为 Paddle 新增 householder_product API docs#6334

paddle-bot · 2023-10-18T19:28:38Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

lxd-cumt · 2023-11-13T02:16:23Z

test/legacy_test/test_householder_product.py

+    def test_error(self):
+        with self.assertRaises(AssertionError):
+            x = paddle.randn([3, 2, 1], dtype=paddle.float32)
+            tau = paddle.randn([6, 5, 4], dtype=paddle.float64)


如果只是判断shape dismatch，是否需要控制dtype相同

已修改，辛苦review~

lxd-cumt · 2023-11-13T02:16:33Z

test/legacy_test/test_householder_product.py

+    def test_error(self):
+        with self.assertRaises(AssertionError):
+            x = paddle.randn([3, 6], dtype=paddle.float32)
+            tau = paddle.randn([6], dtype=paddle.float64)


已修改，辛苦review~

luotao1 · 2023-11-13T09:35:14Z

CodeStyle和Windows-inference流水线没有过

lxd-cumt · 2023-11-14T12:17:34Z

python/paddle/tensor/linalg.py

+        "and the dimension of A is 1 larger than the dimension of tau\n"
+    )
+    assert (
+        A.shape[-2] >= A.shape[-1]


这里是保证A矩阵的m >= n吗，tau矩阵是否要保证 n >= k？

householder_product当前实现方案支持了实值，torch中有对复数的支持吗

辛苦review~

这里是保证A矩阵的m >= n吗，tau矩阵是否要保证 n >= k？

是的，这里应该在加一些assert和对应的单测，我稍后补上，限制条件发现了一些小bug

householder_product当前实现方案支持了实值，torch中有对复数的支持吗?

是的，我当时直接用了paddle.norm（它暂时没支持复数实现），不过应该可以直接手动实现一下norm，我稍后试下再补上相应单测~

…oshe/Paddle into householder_product_coco_dev

lxd-cumt · 2023-11-16T05:36:14Z

python/paddle/tensor/linalg.py

+            A.shape[idx] == tau.shape[idx]
+        ), "The input A must have the same batch dimensions with input tau.\n"
+
+    def _norm(x):


这个函数有用到吗

这个函数有用到吗

噢这个_norm应该用不到，我稍后删掉（本来用来解决complex类型时候的norm用）
话说像现在这个ci是我这边的啥问题嘛？今天早上好像就改了下codestyle
https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/9536759/job/24450158

这个不是你的问题，是那个单测有一些问题

https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/9538644/job/24453315
好怪为啥我的pre-commit本地可以pass，但是ci里面却报错

@cocoshe 昨天isort更新版本了，可以拉一下最新代码，然后重新precommit一下

@cocoshe 昨天isort更新版本了，可以拉一下最新代码，然后重新precommit一下

okk~

… householder_product_coco_dev

lxd-cumt

LGTM

python/paddle/linalg.py

jeff41404 · 2023-11-20T07:38:59Z

python/paddle/tensor/linalg.py

@@ -3724,3 +3724,133 @@ def cdist(
    return paddle.linalg.norm(
        x[..., None, :] - y[..., None, :, :], p=p, axis=-1
    )
+
+
+def householder_product(A, tau, name=None):


according to API naming conventions, enter the name of Tensor using x, and the rfc should also be modified synchronously

… householder_product_coco_dev

jeff41404

LGTM

luotao1 · 2023-11-22T06:47:16Z

请提交中文文档PR

python/paddle/tensor/linalg.py

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>

sunzhongkai588

LGTM～
预览链接暂时挂了，辛苦在合入的第二天，直接去官网API文档的 develop 分支里看下，是否有格式问题～（肉眼看暂时没问题） @cocoshe

cocoshe · 2023-11-30T07:36:35Z

LGTM～
预览链接暂时挂了，辛苦在合入的第二天，直接去官网API文档的 develop 分支里看下，是否有格式问题～（肉眼看暂时没问题） @cocoshe

ok我到时候确认一下，之前自己本地vscode插件渲染看过一下

add householder_product api

5f627a5

paddle-bot bot added the contributor External developers label Oct 18, 2023

luotao1 added the PaddlePaddle Hackathon label Oct 19, 2023

luotao1 assigned luotao1 and lxd-cumt Oct 19, 2023

Ligoml mentioned this pull request Oct 20, 2023

【PaddlePaddle Hackathon 5th】开源贡献个人挑战赛 #57262

Open

cocoshe added 2 commits October 22, 2023 03:01

fix codestyle

1dcde7a

fix conflict

ce7f286

lxd-cumt reviewed Nov 13, 2023

View reviewed changes

cocoshe added 3 commits November 13, 2023 05:26

fix bug, detail describe for tests

708fd5d

codestyle

75c9e06

fix type error desc

3f30938

codestyle, modify atol

1c49aa4

cocoshe requested a review from lxd-cumt November 14, 2023 09:13

lxd-cumt reviewed Nov 14, 2023

View reviewed changes

cocoshe added 3 commits November 16, 2023 00:58

assert when k > n, support complex, add more test units

8899ce7

codestyle

f477ba5

Merge branch 'householder_product_coco_dev' of https://github.com/coc…

3bedcfa

…oshe/Paddle into householder_product_coco_dev

cocoshe requested a review from lxd-cumt November 16, 2023 02:40

lxd-cumt reviewed Nov 16, 2023

View reviewed changes

cocoshe added 3 commits November 16, 2023 06:12

remove unused norm func

d43aaba

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

173a4cd

… householder_product_coco_dev

codestyle

ac67f4a

lxd-cumt approved these changes Nov 17, 2023

View reviewed changes

luotao1 assigned jeff41404 and sunzhongkai588 Nov 17, 2023

jeff41404 reviewed Nov 20, 2023

View reviewed changes

python/paddle/linalg.py Show resolved Hide resolved

jeff41404 reviewed Nov 20, 2023

View reviewed changes

cocoshe added 5 commits November 22, 2023 01:24

modify api param:A to x

1645665

merge

8bfcd24

restore noqa

b5559d3

remove unused func

b92a244

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

67c350d

… householder_product_coco_dev

jeff41404 previously approved these changes Nov 22, 2023

View reviewed changes

sunzhongkai588 reviewed Nov 23, 2023

View reviewed changes

python/paddle/tensor/linalg.py Outdated Show resolved Hide resolved

python/paddle/tensor/linalg.py Outdated Show resolved Hide resolved

cocoshe dismissed jeff41404’s stale review via 8f64185 November 24, 2023 04:43

cocoshe and others added 2 commits November 24, 2023 12:43

Update python/paddle/tensor/linalg.py

8f64185

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>

Update python/paddle/tensor/linalg.py

77aafeb

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>

cocoshe mentioned this pull request Nov 24, 2023

【Hackathon 5th No.37】为 Paddle 新增 householder_product API PaddlePaddle/docs#6334

Merged

Merge branch 'develop' into householder_product_coco_dev

d8c3ef1

sunzhongkai588 approved these changes Nov 30, 2023

View reviewed changes

luotao1 changed the title ~~【Hackathon 5th No.37】为 Paddle 新增 householder_product API~~ 【Hackathon 5th No.37】为 Paddle 新增 householder_product API -part Nov 30, 2023

luotao1 merged commit b991d83 into PaddlePaddle:develop Nov 30, 2023
28 of 30 checks passed

cocoshe deleted the householder_product_coco_dev branch December 1, 2023 02:49

cocoshe mentioned this pull request Dec 8, 2023

[WeeklyReports] 2023.11.26~2023.12.10 周报收集 PFCCLab/Starter#37

Closed

26 tasks

cocoshe mentioned this pull request Jan 19, 2024

[WeeklyReports] 2023.12.25~2024.1.19 周报收集 PFCCLab/Starter#97

Closed

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 5th No.37】为 Paddle 新增 householder_product API -part #58214

【Hackathon 5th No.37】为 Paddle 新增 householder_product API -part #58214

cocoshe commented Oct 18, 2023 •

edited

Loading

paddle-bot bot commented Oct 18, 2023

lxd-cumt Nov 13, 2023

cocoshe Nov 13, 2023

lxd-cumt Nov 13, 2023

cocoshe Nov 13, 2023

luotao1 commented Nov 13, 2023

lxd-cumt Nov 14, 2023

lxd-cumt Nov 14, 2023

cocoshe Nov 14, 2023

lxd-cumt Nov 15, 2023

lxd-cumt Nov 16, 2023

cocoshe Nov 16, 2023 •

edited

Loading

lxd-cumt Nov 16, 2023

cocoshe Nov 16, 2023 •

edited

Loading

luotao1 Nov 16, 2023

cocoshe Nov 16, 2023

lxd-cumt left a comment

jeff41404 Nov 20, 2023

jeff41404 left a comment

luotao1 commented Nov 22, 2023

sunzhongkai588 left a comment

cocoshe commented Nov 30, 2023

【Hackathon 5th No.37】为 Paddle 新增 householder_product API -part #58214

【Hackathon 5th No.37】为 Paddle 新增 householder_product API -part #58214

Conversation

cocoshe commented Oct 18, 2023 • edited Loading

PR types

PR changes

Description

paddle-bot bot commented Oct 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

luotao1 commented Nov 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cocoshe Nov 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cocoshe Nov 16, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lxd-cumt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

luotao1 commented Nov 22, 2023

sunzhongkai588 left a comment

Choose a reason for hiding this comment

cocoshe commented Nov 30, 2023

cocoshe commented Oct 18, 2023 •

edited

Loading

cocoshe Nov 16, 2023 •

edited

Loading

cocoshe Nov 16, 2023 •

edited

Loading