【Hackathon 5th No.52】 为 Paddle 新增 unsqueeze 的 spmd 切分推导规则 -part #58296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@pkuzyc 老师您好，CI已过，可以review了 |
|
Sorry to inform you that c33990f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
pkuzyc
reviewed
Oct 30, 2023
| // Step1: Build the transformation from | ||
| // the original shape to the target shape | ||
|
|
||
| std::vector<int64_t> out_shape(x_shape); |
|
|
||
| std::vector<DimTrans*> MakeUnsqueezeDimTransReverse( | ||
| const std::vector<int64_t>& out_shape, const std::vector<int64_t>& axis) { | ||
| int64_t n = static_cast<int64_t>(out_shape.size() - axis.size()); |
There was a problem hiding this comment.
reverse 里输入的 rank 应该是知道的 (x_ndim)，不用计算。
|
@pkuzyc 修改完毕，可以再次review了 |
luotao1
changed the title
pkuzyc
reviewed
Nov 4, 2023
| const std::vector<int64_t>& out_shape, | ||
| const std::vector<int64_t>& axis, | ||
| const int& x_ndim, | ||
| const int& out_ndim) { |
There was a problem hiding this comment.
整型参数直接传 int 就可以，不用传 const 引用，可以在下个 pr 修复
luotao1
approved these changes
Nov 6, 2023
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
…lePaddle#58296) * add unsqueeze spmd rules * fix bugs * fix bugs * modify the code based on the first review * fix bugs
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…lePaddle#58296) * add unsqueeze spmd rules * fix bugs * fix bugs * modify the code based on the first review * fix bugs
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…lePaddle#58296) * add unsqueeze spmd rules * fix bugs * fix bugs * modify the code based on the first review * fix bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
为 Paddle 新增 squeeze 和 unsqueeze 的 spmd 切分推导规则
#57262
https://github.com/PaddlePaddle/community/blob/master/pfcc/paddle-code-reading/auto_parallel/spmd_rules.md
【Hackathon 5th No.52】 为 Paddle 新增 squeeze 和 unsqueeze 的 spmd 切分推导规则 #57877