Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nccl trace #58338

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix nccl trace #58338

merged 3 commits into from
Oct 24, 2023

Conversation

hitywt
Copy link
Contributor

@hitywt hitywt commented Oct 24, 2023

PR types

Others

PR changes

Others

Description

Pcard-70448

  1. comm trace function instance exits when training process finished

@paddle-bot
Copy link

paddle-bot bot commented Oct 24, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit a5274e2 into PaddlePaddle:incubate/new_frl Oct 24, 2023
5 of 6 checks passed
hitywt added a commit to hitywt/Paddle that referenced this pull request Oct 26, 2023
Fix nccl trace

* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 7, 2023
Fix nccl trace

* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 8, 2023
Fix nccl trace

* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 9, 2023
Fix nccl trace

* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 14, 2023
Fix nccl trace

* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 21, 2023
* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 24, 2023
* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 27, 2023
* fix nccl_async_trace destruct problem when train finished

* update

* format code style
ForFishes added a commit that referenced this pull request Nov 28, 2023
* add comm async trace module, (#56916)

* Fix trace hang (#57536)

* fix trace hang

* fix compile error

* fix code style

* tinyfix

* tiny update

* fix code style

---------

Co-authored-by: ForFishes <1422485404@qq.com>

* Fix nccl trace (#58338)

* fix nccl_async_trace destruct problem when train finished

* update

* format code style

* optimize trace hang && fix event leak (#58707)

* update

* fix compile problems

* fix code style

* fix logging

* fix code style

* remove useless

* add ut && tinyfix

* opt cudaMalloc and cudaMemcpy

update

* tinyfix

---------

Co-authored-by: ForFishes <1422485404@qq.com>
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 28, 2023
* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Nov 28, 2023
* fix nccl_async_trace destruct problem when train finished

* update

* format code style
hitywt added a commit to hitywt/Paddle that referenced this pull request Dec 4, 2023
* fix nccl_async_trace destruct problem when train finished

* update

* format code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants