【PIR API adaptor No.206、207】 Migrate paddle.sign/sinh into pir #58377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
Aurelius84
approved these changes
Oct 30, 2023
|
这里sign单测没有覆盖全吧 |
|
写错了，已改 |
0x45f
approved these changes
Oct 30, 2023
zeroRains
pushed a commit
to zeroRains/Paddle
that referenced
this pull request
Nov 8, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
No.206 sign
No.207 sinh
PIR API 推全升级
将
paddle.sign迁移升级至 pir，并更新单测 单测覆盖率：3/6TODO：目前缺少适配
test/legacy_test/test_sign.py内TestSignDoubleGradCheck和TestSignTripleGradCheck的单测。原因是当前不支持
gradient_checker.double_grad_check和gradient_checker.triple_grad_check在 pir 体系下运行，具体的适配问题包括但不限于：目前缺少从 python 端获取 OpResult.name 的支持
将
paddle.sinh迁移升级至 pir，并更新单测 单测覆盖率：6/6