Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_repeat_interleave_op #58379

Merged
merged 15 commits into from
Oct 31, 2023

Conversation

xingmingyyj
Copy link
Contributor

@xingmingyyj xingmingyyj commented Oct 25, 2023

PR types

Others

PR changes

Others

Description

修复repeat_interleave_op
问什么会对test_repeat_interleave_op.py进行修改?

        self.data_zero_dim_x = np.array(0.5)
        x = paddle.static.data(name='x', shape=[-1, 4], dtype='float32')

data_zero_dim_x数据类型为float64,组网时定义的输入的dtypefloat32,旧Ir下的GetExpectedKernelType函数可以根据输入的数据的数据类型选择kernel,而新ir下暂不支持,新ir下根据xdtype选择对应的kernel

@paddle-bot
Copy link

paddle-bot bot commented Oct 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 25, 2023
Comment on lines 1994 to 1996
special_handlers["repeat_interleave"] = RepeatInterLeaveOpTranscriber();
special_handlers["repeat_interleave_grad"] =
RepeatInterLeaveGradOpTranscriber();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里按照字母序排列好一些,辛苦顺便把其他的顺序也调整下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@@ -211,3 +211,4 @@ test_where_op
test_yolo_box_op
test_yolov3_loss_op
test_imperative_lod_tensor_to_selected_rows
test_repeat_interleave_op
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同理,这里按照字母序排列,可以在这个目录下增加一个pre-commit配置,避免每次都手动排序

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改 后面单独提pr添加pre-commit配置

Copy link
Contributor

@kangguangli kangguangli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op_compat

@kangguangli kangguangli merged commit ffd3392 into PaddlePaddle:develop Oct 31, 2023
28 checks passed
@xingmingyyj xingmingyyj deleted the fix_repeat_interleave branch October 31, 2023 09:50
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
* fix_repeat_interleave_op

* fix repeat_interleave

* fix

* fix

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix style

* fix style
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* fix_repeat_interleave_op

* fix repeat_interleave

* fix

* fix

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix codestyle

* fix style

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants