Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Add Dtype Transfer for pir #58397

Merged
merged 25 commits into from Nov 7, 2023

Conversation

chen2016013
Copy link
Contributor

PR types

Others

PR changes

Others

Description

PCard-67164

为pir添加Dtype Transfer功能,修复elementwise_add测试中complex和real类型运算报错的问题

@paddle-bot
Copy link

paddle-bot bot commented Oct 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 26, 2023
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023

OP_GET_KERNEL_TYPE_FOR_VAR_TEMPLATE = """
phi::DataType {op_name}::GetKernelTypeForVar(
const std::string& var_name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var_name 有必要么?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有必要

//pd_op.cc
// deal skip data transform
if (var_name == "out_size" || var_name == "size_tensor" || var_name == "scale_tensor"){
    return expected_kernel_dtype;
}

@@ -1866,6 +1866,9 @@
outputs :
out : Y

- op : matmul
complex_promote : [X, Y]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面的 matmul 已经有该标记了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已删除

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chen2016013 chen2016013 merged commit cb88a2e into PaddlePaddle:develop Nov 7, 2023
28 checks passed
jiahy0825 pushed a commit to jiahy0825/Paddle that referenced this pull request Nov 7, 2023
* add log

* add getkerneltype func by yaml

* delete VLOG

* update

* change kernelkey to datatype

* update

* move util functions into pd_op_lower_to_kernel_pass
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
* add log

* add getkerneltype func by yaml

* delete VLOG

* update

* change kernelkey to datatype

* update

* move util functions into pd_op_lower_to_kernel_pass
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* add log

* add getkerneltype func by yaml

* delete VLOG

* update

* change kernelkey to datatype

* update

* move util functions into pd_op_lower_to_kernel_pass
@chen2016013 chen2016013 deleted the datatransfer branch November 15, 2023 10:31
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* add log

* add getkerneltype func by yaml

* delete VLOG

* update

* change kernelkey to datatype

* update

* move util functions into pd_op_lower_to_kernel_pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants