Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【SOT】fix sot memory leakage when fallback #58423

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

2742195759
Copy link
Contributor

@2742195759 2742195759 commented Oct 26, 2023

PR types

Performance optimization

PR changes

Others

Description

fix sot memory leakage when fallback

  1. 延迟释放问题
  2. 解决了泄漏的 frame 问题,使用 sys.getrefcount 还是可以比较好的二分定位到代码的位置。

PCard-66972

@paddle-bot
Copy link

paddle-bot bot commented Oct 26, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Oct 26, 2023
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@2742195759 2742195759 closed this Oct 31, 2023
@2742195759 2742195759 reopened this Oct 31, 2023
@2742195759 2742195759 marked this pull request as draft October 31, 2023 06:24
@2742195759 2742195759 marked this pull request as ready for review October 31, 2023 06:25
@2742195759 2742195759 merged commit 3d6b6b2 into PaddlePaddle:develop Nov 1, 2023
28 checks passed
@2742195759 2742195759 deleted the fix-sot-memory-problem branch November 1, 2023 11:04
@paddle-bot paddle-bot bot removed the contributor External developers label Nov 3, 2023
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
* fix sot memory leakage when fallback

* inplace clean call_stack

* [bugfix] fix layer created in forward function bugs: add check and make weakref to string ref.

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
* fix sot memory leakage when fallback

* inplace clean call_stack

* [bugfix] fix layer created in forward function bugs: add check and make weakref to string ref.

---------

Co-authored-by: SigureMo <sigure.qaq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants