Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.50、57、67】fix for 58466 #58541

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

longranger2
Copy link
Contributor

@longranger2 longranger2 commented Oct 31, 2023

PR types

Others

PR changes

APIs

Description

将cumprod和digamma剩余的单测都打开

@paddle-bot paddle-bot bot added the contributor External developers label Oct 31, 2023
test/legacy_test/test_cumprod_op.py Outdated Show resolved Hide resolved
test/legacy_test/test_digamma_op.py Outdated Show resolved Hide resolved
@longranger2
Copy link
Contributor Author

done

Copy link

paddle-bot bot commented Nov 2, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@MarioLulab
Copy link
Contributor

PR-CI-Py3 的报错信息来看:ci 挂在了 test/legacy_test/test_digamma_op.py。目前场景下,在 pir 模式中,应该不支持直接使用 OpResult.name,可以作如下修改试试:

    @test_with_pir_api
    def test_in_static_mode(self):
        def init_input_output(dtype):
            input = np.random.random(self._shape).astype(dtype)
            return {'x': input}, psi(input)
        for dtype in self.dtypes:
            input_dict, sc_res = init_input_output(dtype)
            for place in self.places:
                with static.program_guard(static.Program()):
                    x = static.data(name="x", shape=self._shape, dtype=dtype)
                    out = paddle.digamma(x)
                    exe = static.Executor(place)
                    # out_value = exe.run(feed=input_dict, fetch_list=[out.name])     # <--------- 报错的地方
                    # 改成试试:
                    out_value = exe.run(feed=input_dict, fetch_list=[out]) 
                    np.testing.assert_allclose(out_value[0], sc_res, rtol=1e-05)

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 3, 2023
@0x45f 0x45f merged commit 941a84c into PaddlePaddle:develop Nov 3, 2023
28 checks passed
zeroRains pushed a commit to zeroRains/Paddle that referenced this pull request Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants