Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.198-201】Migrate paddle.incubate.graph_send_recv, paddle.geometric.send_u_recv, paddle.geometric.send_ue_recv, paddle.geometric.send_uv into pir #58582

Merged
merged 9 commits into from
Nov 8, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Nov 1, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
paddle.incubate.graph_send_recv 迁移升级至 pir,并更新单测 单测覆盖率:5/5
paddle.geometric.send_u_recv 迁移升级至 pir,并更新单测 单测覆盖率:1/1
paddle.geometric.send_ue_recv 迁移升级至 pir,并更新单测 单测覆盖率:33/33
paddle.geometric.send_uv 迁移升级至 pir,并更新单测 单测覆盖率:9/9

3个的static_test,在添加out_size参数后,都有同样的错误:
2023-11-02 18:38:26 out_size = convert_out_size_to_list(out_size)
2023-11-02 18:38:26 File "C:\home\workspace\Paddle\build\python\paddle\geometric\message_passing\utils.py", line 32, in convert_out_size_to_list
2023-11-02 18:38:26 out_size = [int(out_size)]
2023-11-02 18:38:26 TypeError: int() argument must be a string, a bytes-like object or a real number, not 'paddle.base.libpaddle.pir.OpResult'

@paddle-bot paddle-bot bot added the contributor External developers label Nov 1, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 3, 2023
@YuanRisheng
Copy link
Contributor

这里的问题说明新IR代码无法复用动态图的逻辑,可以尝试新建一个pir的分支,在out_size是OpResult的场景下,可以参考以下代码的逻辑进行处理:
image

@enkilee
Copy link
Contributor Author

enkilee commented Nov 7, 2023

already done.

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work~
但是还存在一些问题,请修改一下吧 ~

python/paddle/geometric/message_passing/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit f1de995 into PaddlePaddle:develop Nov 8, 2023
28 checks passed
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…paddle.geometric.send_u_recv, paddle.geometric.send_ue_recv, paddle.geometric.send_uv into pir (PaddlePaddle#58582)

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
…paddle.geometric.send_u_recv, paddle.geometric.send_ue_recv, paddle.geometric.send_uv into pir (PaddlePaddle#58582)

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix
@enkilee enkilee deleted the pir-api-198-201 branch December 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants