-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR API adaptor No.198-201】Migrate paddle.incubate.graph_send_recv, paddle.geometric.send_u_recv, paddle.geometric.send_ue_recv, paddle.geometric.send_uv into pir #58582
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
already done. |
MarioLulab
reviewed
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work~
但是还存在一些问题,请修改一下吧 ~
MarioLulab
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YuanRisheng
approved these changes
Nov 8, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
…paddle.geometric.send_u_recv, paddle.geometric.send_ue_recv, paddle.geometric.send_uv into pir (PaddlePaddle#58582) * fix * fix * fix * fix * fix * fix * fix * fix * fix
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
…paddle.geometric.send_u_recv, paddle.geometric.send_ue_recv, paddle.geometric.send_uv into pir (PaddlePaddle#58582) * fix * fix * fix * fix * fix * fix * fix * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
将
paddle.incubate.graph_send_recv
迁移升级至 pir,并更新单测 单测覆盖率:5/5将
paddle.geometric.send_u_recv
迁移升级至 pir,并更新单测 单测覆盖率:1/1将
paddle.geometric.send_ue_recv
迁移升级至 pir,并更新单测 单测覆盖率:33/33将
paddle.geometric.send_uv
迁移升级至 pir,并更新单测 单测覆盖率:9/93个的static_test,在添加out_size参数后,都有同样的错误:
2023-11-02 18:38:26 out_size = convert_out_size_to_list(out_size)
2023-11-02 18:38:26 File "C:\home\workspace\Paddle\build\python\paddle\geometric\message_passing\utils.py", line 32, in convert_out_size_to_list
2023-11-02 18:38:26 out_size = [int(out_size)]
2023-11-02 18:38:26 TypeError: int() argument must be a string, a bytes-like object or a real number, not 'paddle.base.libpaddle.pir.OpResult'