Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.218、223】Migrate PairwiseDistance / take_along_axis into pir #58689

Merged
merged 8 commits into from
Nov 8, 2023
Merged

Conversation

DrRyanHuang
Copy link
Member

@DrRyanHuang DrRyanHuang commented Nov 4, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
将 paddle.nn.PairwiseDistance / take_along_axis 迁移升级至 pir,并更新单测

PairwiseDistance 全部通过
take_along_axis 全部通过

Copy link

paddle-bot bot commented Nov 4, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 4, 2023
@DrRyanHuang DrRyanHuang changed the title 【PIR api adaptor No.218、223】Migrate PairwiseDistance / take_along_axis into pir 【PIR API adaptor No.218、223】Migrate PairwiseDistance / take_along_axis into pir Nov 5, 2023
@DrRyanHuang

This comment was marked as duplicate.

@MarioLulab
Copy link
Contributor

目前还有这几个问题,似乎需要修改单测代码,为pir mode适配

ERROR: test_check_grad (test_take_along_axis_op.TestCase1)
TypeError: Cannot interpret '<DataType.INT32: 7>' as a data type

ERROR: test_check_output (test_take_along_axis_op.TestCase1)
TypeError: Cannot interpret '<DataType.INT32: 7>' as a data type

ERROR: test_api_static (test_take_along_axis_op.TestTakeAlongAxisAPI)
TypeError: Cannot interpret '<DataType.INT64: 9>' as a data type

ERROR: test_api_static (test_take_along_axis_op.TestTakeAlongAxisAPICase1)
TypeError: Cannot interpret '<DataType.INT64: 9>' as a data type

ERROR: test_check_grad (test_take_along_axis_op.TestTakeAlongAxisOp)
TypeError: Cannot interpret '<DataType.INT32: 7>' as a data type

ERROR: test_check_output (test_take_along_axis_op.TestTakeAlongAxisOp)
TypeError: Cannot interpret '<DataType.INT32: 7>' as a data type

请问有更为完整的报错栈吗?

@DrRyanHuang

This comment was marked as resolved.

@YuanRisheng
Copy link
Contributor

take_along_axis这个api使用到了其他python api,所以需要递归把它调用到的api全部适配pir

@DrRyanHuang DrRyanHuang changed the title 【PIR API adaptor No.218、223】Migrate PairwiseDistance / take_along_axis into pir 【PIR API adaptor No.218、223、29】Migrate PairwiseDistance / take_along_axis into pir Nov 7, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

btw, 29 号题目是 paddle.broadcast_tensors,这个 pr 应该并没有涉及?麻烦修改一下 pr 标题吧~
image

@YuanRisheng YuanRisheng merged commit 6f1ab3f into PaddlePaddle:develop Nov 8, 2023
28 checks passed
@DrRyanHuang DrRyanHuang deleted the PairwiseDistance branch November 8, 2023 07:34
@DrRyanHuang DrRyanHuang changed the title 【PIR API adaptor No.218、223、29】Migrate PairwiseDistance / take_along_axis into pir 【PIR API adaptor No.218、223】Migrate PairwiseDistance / take_along_axis into pir Nov 8, 2023
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…axis into pir (PaddlePaddle#58689)

* PairwiseDistance take_along_axis

* add OpResult

* fix epsilon to_variable && rm test_with_pir_api of test_static

* disable_static

* add broadcast_to test

* rm test_errors of test_broadcast_to_op.TestBroadcastToError

* add some utest
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
…axis into pir (PaddlePaddle#58689)

* PairwiseDistance take_along_axis

* add OpResult

* fix epsilon to_variable && rm test_with_pir_api of test_static

* disable_static

* add broadcast_to test

* rm test_errors of test_broadcast_to_op.TestBroadcastToError

* add some utest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants