Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.23】Migrate paddle.Tensor.bincount into pir #58692

Merged
merged 4 commits into from
Nov 8, 2023
Merged

【PIR API adaptor No.23】Migrate paddle.Tensor.bincount into pir #58692

merged 4 commits into from
Nov 8, 2023

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Nov 5, 2023

PR types

Others

PR changes

Others

Description

Migrate paddle.Tensor.bincount into pir

@paddle-bot paddle-bot bot added the contributor External developers label Nov 5, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 6, 2023
@MarioLulab
Copy link
Contributor

@MarioLulab
Copy link
Contributor

MarioLulab commented Nov 7, 2023

目前 pir 模式下暂不支持 paddle.static.save_inference_model,可以先跳过 ci 对应的单测,然后在 pr 描述里注明

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
麻烦在 pr 描述里写一下 test_errors 的单测和 paddle.static.save_inference_model 相关的单测不支持吧~ 方便我们后续去解决这些问题

@YuanRisheng YuanRisheng merged commit e5ef5d3 into PaddlePaddle:develop Nov 8, 2023
28 checks passed
@GreatV GreatV deleted the pir_bincount branch November 8, 2023 11:28
Copy link

paddle-bot bot commented Nov 10, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
…ePaddle#58692)

* 【PIR API adaptor No.23】Migrate paddle.Tensor.bincount into pir

* fix bug

* fix bug

* Update test/legacy_test/test_bincount_op.py

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

---------

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
…ePaddle#58692)

* 【PIR API adaptor No.23】Migrate paddle.Tensor.bincount into pir

* fix bug

* fix bug

* Update test/legacy_test/test_bincount_op.py

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

---------

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants