【PIR API adaptor No.65, 69】Migrate some ops into pir #58698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MarioLulab
reviewed
Nov 13, 2023
| @@ -1199,7 +1199,7 @@ def _check_attr(attr, message): | |||
| else: | |||
| num_columns = num_rows | |||
|
|
|||
| if in_dynamic_mode(): | |||
| if in_dynamic_or_pir_mode(): | |||
There was a problem hiding this comment.
这里的适配有些问题。上面的 _check_attr 应该还需要适配 OpResult 的情况：
MarioLulab
reviewed
Nov 19, 2023
python/paddle/tensor/creation.py
Outdated
| @@ -2177,7 +2179,7 @@ def empty_like(x, dtype=None, name=None): | |||
| dtype = x.dtype | |||
| dtype = convert_dtype(dtype) | |||
|
|
|||
| if in_dynamic_mode(): | |||
| if in_dynamic_or_pir_mode(): | |||
There was a problem hiding this comment.
这里静态图多了一些处理逻辑，有时候动态图逻辑是不能复用的，需要有pir自己的逻辑的
可修改如下：
elif in_pir_mode():
shape = paddle.shape(x)
out = _C_ops.empty(
shape,
convert_np_dtype_to_dtype_(dtype),
_current_expected_place(),
)
out.stop_gradient = True
return out
test/legacy_test/test_eye_op.py
Outdated
| @@ -144,6 +145,7 @@ def init_info(self): | |||
| self.shapes = [[2, 3, 4]] | |||
| self.save_path = os.path.join(self.temp_dir.name, self.path_prefix()) | |||
|
|
|||
| @test_with_pir_api | |||
There was a problem hiding this comment.
可以先跳过这个单测，然后在 PR 描述里记录该单测暂不支持
|
Sorry to inform you that ba8dc2b's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
long 师傅这个 pr 还在推进吗~ |
推的哈哈，最近比较忙~ |
done |
MarioLulab
reviewed
Nov 24, 2023
There was a problem hiding this comment.
这个文件下还缺少了 API_TestTensorEye 单测没有适配，辛苦有空的时候适配一下吧~ 😄
There was a problem hiding this comment.
这个文件下继承自 TestEmptyLikeAPICommon 的单测均为动态图单测，不在本次组网API PIR 迁移的单测覆盖目标内。目前看来 empty_like 的单测中，除了 TestEmptyError 尚未支持，其他都已经适配了。所以请更新一下 pr 描述里的单测覆盖率吧~
0x45f
approved these changes
Nov 27, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
将如下算子迁移升级至 pir，并更新单测
empty_like（3/3）
这个文件下继承自 TestEmptyLikeAPICommon 的单测均为动态图单测，不在本次组网API PIR 迁移的单测覆盖目标内。目前在 empty_like 的单测中，除了 TestEmptyError 尚未支持，其他都已经适配了
eye（5/7）:TestEyeRowsCol暂时不支持
新IR Python API适配升级 #58067