Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PIR]Migrate Momentum into pir #58730

Merged
merged 8 commits into from
Nov 9, 2023
Merged

[PIR]Migrate Momentum into pir #58730

merged 8 commits into from
Nov 9, 2023

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Nov 6, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

[PIR]Migrate Momentum into pir

  • 继承自OpTest的6个单测都已经打开了
  • 两个继承自TestCase的单测TestMomentumV2和TestMomentumOpWithDecayAPI也已经适配打开
  • TestFusedMomentumWithDecayAPI中的test_param_has_l2decay、test_param_has_l1decay、test_param_has_no_regularizer测试的是program中是否存在某些op。因为pir下op name和顺序和老IR下不一致了，所以没有打开这几个测试case

Pcard-67164

@0x45f 0x45f closed this Nov 9, 2023
@0x45f 0x45f reopened this Nov 9, 2023
Aurelius84
Aurelius84 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 54ac5b5 into PaddlePaddle:develop Nov 9, 2023
28 checks passed
@0x45f 0x45f deleted the pir-Momentum branch November 9, 2023 08:23
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 10, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
@0x45f
[PIR]Migrate Momentum into pir (PaddlePaddle#58730)
8955de9
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@0x45f @SecretXV
[PIR]Migrate Momentum into pir (PaddlePaddle#58730)
2bb0c78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0x45f @Aurelius84 @wanghuancoder @YuanRisheng