【PIR API adaptor No.224】 Migrate paddle.tan #58737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MarioLulab
suggested changes
Nov 7, 2023
| @@ -1960,7 +1960,7 @@ def init_shape(self): | |||
| def test_check_grad(self): | |||
| if self.dtype == np.float16: | |||
| return | |||
| self.check_grad(['X'], 'Out') | |||
| self.check_grad(['X'], 'Out', check_pir=True) | |||
There was a problem hiding this comment.
TestTan 继承自 TestActivation. TestActivation 有一个 test_check_output 需要继承重写并打开 check_pir 开关。麻烦添加一下吧~
| @@ -4745,7 +4746,7 @@ def test_check_grad(self): | |||
| check_pir=True, | |||
| ) | |||
| create_test_act_fp16_class(TestCos, check_pir=True) | |||
| create_test_act_fp16_class(TestTan) | |||
| create_test_act_fp16_class(TestTan, check_pir=True) | |||
There was a problem hiding this comment.
类似于 create_test_act_fp16_class, 在该文件内还有一个 create_test_act_bf16_class(TestTan) 创建了 bf16 的单测，麻烦也打开一下吧~
YuanRisheng
approved these changes
Nov 8, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* feat(new-ir): support tan * feat(new-ir): update ut of tan
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* feat(new-ir): support tan * feat(new-ir): update ut of tan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
将 paddle.Tensor.log2 迁移升级至 pir，并更新单测
#58067
单测覆盖率：4/4