-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dropout op in pir #58773
Merged
phlrain
merged 47 commits into
PaddlePaddle:develop
from
phlrain:support_dropout_op_in_pir
Nov 10, 2023
Merged
Support dropout op in pir #58773
phlrain
merged 47 commits into
PaddlePaddle:develop
from
phlrain:support_dropout_op_in_pir
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix complation problem
… test_reduce_max_broadcast_kernel
… fix_op_fusion_pass_bug
… test_reduce_max_broadcast_kernel
…e/Paddle into test_reduce_max_broadcast_kernel
…e/Paddle into fix_op_fusion_pass_bug
… fix_op_fusion_pass_bug
…e/Paddle into test_cinn_pir_all_path
… test_cinn_pir_all_path
… test_cinn_pir_all_path
… support_dropout_op_in_pir
…e/Paddle into support_dropout_op_in_pir
… support_layer_norm_lowering_cinn_pir
… support_layer_norm_lowering_cinn_pir
… support_dropout_op_in_pir
… support_layer_norm_lowering_cinn_pir
… support_layer_norm_lowering_cinn_pir
…e/Paddle into support_dropout_op_in_pir
… support_dropout_op_in_pir
Aurelius84
previously approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以单独PR fix
@@ -42,11 +42,13 @@ std::unordered_map<std::string, OpPatternKind> OpKindMap = { | |||
{"pd_op.exp", OpPatternKind::kElementWise}, | |||
{"pd_op.sin", OpPatternKind::kElementWise}, | |||
{"pd_op.cos", OpPatternKind::kElementWise}, | |||
{"pd_op.cast", OpPatternKind::kElementWise}, | |||
{"pd_op.greater_than", OpPatternKind::kElementWise}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里如果是与CINN 对齐OpPatternKind的话,可以使用CompatibleInfo::OpKind(op)来获取,若有op name 差异性,也仅需配置下CompatibleInfo下的Op_NAMES映射表即可,可省去重复维护的成本。
… support_dropout_op_in_pir
… support_dropout_op_in_pir
… support_dropout_op_in_pir
Aurelius84
approved these changes
Nov 10, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* [CINN+PIR]Support DoGroupSchedule for PIRComppiler fix complation problem * fix conflict * support cinn broadcast code gen * fix op fusion pass bug * using output_ops to parse function arguments * update * fix unittest * remove VLOG(1) * ignore some UT and add FIXME * update * remove args limit * fix bug and remove useless code * update * update * fix bug * update * fix bug * update * update * update * update * remove useless code * merge layer norm manual * remove usless code * remove usless code * remove useless code --------- Co-authored-by: Aurelius84 <zhangliujie@baidu.com>
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* [CINN+PIR]Support DoGroupSchedule for PIRComppiler fix complation problem * fix conflict * support cinn broadcast code gen * fix op fusion pass bug * using output_ops to parse function arguments * update * fix unittest * remove VLOG(1) * ignore some UT and add FIXME * update * remove args limit * fix bug and remove useless code * update * update * fix bug * update * fix bug * update * update * update * update * remove useless code * merge layer norm manual * remove usless code * remove usless code * remove useless code --------- Co-authored-by: Aurelius84 <zhangliujie@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
适配dropout算子在新IR c++层面的全链条,并修复部分的bug
备注:由于cinn当前不能生成uniform的kernel,所以uniform op会调用phi kernel,已经适配的uniform 相关的pass逻辑暂时保留(不调用)
Pcard-67164