【PIR API adaptor No.250】 python/paddle/geometric/sampling/neighbors.py #58783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
看 ci 挂掉的原因貌似是单测加错了，目前好像测的是 |
Liyulingyue
commented
Nov 9, 2023
MarioLulab
reviewed
Nov 10, 2023
There was a problem hiding this comment.
这个文件下的 test_sample_result_with_eids 也可以用 test_with_pir_api
MarioLulab
approved these changes
Nov 10, 2023
0x45f
approved these changes
Nov 10, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
#58067 250
遗漏了 test_sample_result_with_eids 这个单测，单测覆盖率为 1/2