Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.89、226】Migrate paddle.nn.functional.gather_tree,paddle.nn.functional.temporal_shift into pir #58792

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Nov 8, 2023

PR types

Others

PR changes

APIs

Description

  • 新IR Python API适配升级 #58067
    No89
    No226
    PIR API 推全升级
    paddle.nn.functional.gather_tree 迁移升级至 pir,并更新单测 单测覆盖率:4/4
    paddle.nn.functional.temporal_shift 迁移升级至 pir,并更新单测 单测覆盖率:7/7

@paddle-bot paddle-bot bot added the contributor External developers label Nov 8, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 9, 2023
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

with program_guard(Program(), Program()):
ids = paddle.static.data(name='ids', shape=[5, 2, 2], dtype='int64')
parents = paddle.static.data(
name='parents', shape=[5, 2, 2], dtype='int64'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议在 PR 描述里标注 gather_tree 的单测覆盖率。注明这些 test_errors 单测尚未覆盖

@0x45f 0x45f merged commit d97d215 into PaddlePaddle:develop Nov 9, 2023
28 checks passed
danleifeng pushed a commit to danleifeng/Paddle that referenced this pull request Nov 14, 2023
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@enkilee enkilee deleted the pir-api-226 branch December 14, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants