Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.41】为 Paddle 新增 Rprop API -part #58851

Merged
merged 28 commits into from
Dec 20, 2023
Merged

【Hackathon No.41】为 Paddle 新增 Rprop API -part #58851

merged 28 commits into from
Dec 20, 2023

Conversation

WintersMontagne10335
Copy link
Contributor

@WintersMontagne10335 WintersMontagne10335 commented Nov 9, 2023 •
edited
Loading

PR types

Others

PR changes

APIs

Description

为 Paddle 新增 Rprop API

Related links

Current progress

  • Python
  • C++
  • Unit testing passed
  • Complete unit testing cases
  • Add documents

Others

@luotao1 luotao1 mentioned this pull request Nov 9, 2023
Open
@paddle-bot paddle-bot bot added the contributor External developers label Nov 9, 2023
@WintersMontagne10335
Copy link
Contributor Author

@jeff41404
Hello Jeff!
At present, the code structure has been completed and unit testing can run smoothly, with only some minor issues remaining to be fixed. If you have time, you can review it first. please don't stint your comments.
Wishing you a pleasant life！

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Nov 29, 2023

Sorry to inform you that eff0754's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@WintersMontagne10335 WintersMontagne10335 mentioned this pull request Dec 12, 2023
Merged
jeff41404
jeff41404 reviewed Dec 14, 2023
View reviewed changes
python/paddle/optimizer/rprop.py
parameters=None,
etas=(0.5, 1.2),
grad_clip=None,
multi_precision=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter of multi_precision is not present in both docstring above and rfc. If it needs to be added, should modify docstring and rfc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@WintersMontagne10335 WintersMontagne10335 mentioned this pull request Dec 15, 2023
Merged
jeff41404
jeff41404 previously approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sunzhongkai588
sunzhongkai588 reviewed Dec 18, 2023
View reviewed changes
python/paddle/optimizer/rprop.py
Parameters:
learning_rate (float|Tensor|LearningRateDecay, optional): The initial learning rate used to update ``Parameter``.
It can be a float value, a ``Tensor`` with a float type or a LearningRateDecay. The default value is 0.001.
learning_rate_range (tuple, optional): The range of learning rate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

learning_rate_range 和 parameters 加一下默认值的描述吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@luotao1
Copy link
Contributor

luotao1 commented Dec 19, 2023

PR-CI-Codestyle-Check 没过

@WintersMontagne10335
Copy link
Contributor Author

PR-CI-Codestyle-Check 没过

是因为没拉取最新代码，已修正~~

sunzhongkai588
sunzhongkai588 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 01c2242 into PaddlePaddle:develop Dec 20, 2023
29 checks passed
@luotao1 luotao1 changed the title 【Hackathon No.41】为 Paddle 新增 Rprop API 【Hackathon No.41】为 Paddle 新增 Rprop API -part Dec 20, 2023
HermitSun pushed a commit to HermitSun/Paddle that referenced this pull request Dec 21, 2023
@WintersMontagne10335 @HermitSun
【Hackathon No.41】为 Paddle 新增 Rprop API (PaddlePaddle#58851)
5789e55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

@jeff41404 jeff41404 jeff41404 left review comments

Assignees

@luotao1 luotao1

@jeff41404 jeff41404

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WintersMontagne10335 @luotao1 @jeff41404 @sunzhongkai588