Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.36】check_numerics #58879

Merged
merged 10 commits into from Dec 1, 2023
Merged

Conversation

Liyulingyue
Copy link
Contributor

PR types

Others

PR changes

APIs

Description

#58067 36

@paddle-bot paddle-bot bot added the contributor External developers label Nov 9, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 10, 2023
@@ -299,6 +300,7 @@ def test_eager(self):
debug_mode=paddle.amp.debugging.DebugMode.CHECK_ALL,
)

@test_with_pir_api

This comment was marked as resolved.

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前在 pir 模式下无法直接从 python 端获取 OpResult.name,但是可以获取 OpResult 的 id 属性,其为一个 str 类型。故在此处,可以判断当前是否处于 pir 模式,若处于 pir 模式则传入 out.id
image

btw, 需要 merge 一下最新的 develop 分支~

@MarioLulab
Copy link
Contributor

需要 pre-commit 一下

Copy link

paddle-ci-bot bot commented Nov 29, 2023

Sorry to inform you that 08fc435's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@MarioLulab
Copy link
Contributor

需要 pre-commit 一下

@0x45f
Copy link
Contributor

0x45f commented Dec 1, 2023

辛苦在pr描述中添加一下pir单测的覆盖率~

@0x45f 0x45f merged commit 8290a9e into PaddlePaddle:develop Dec 1, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants