Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.109】identity_loss #58880

Merged
merged 8 commits into from
Dec 25, 2023
Merged

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Nov 9, 2023

PR types

Others

PR changes

APIs

Description

#58067 109

覆盖率3/3

@paddle-bot paddle-bot bot added the contributor External developers label Nov 9, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 10, 2023
Copy link

paddle-ci-bot bot commented Nov 19, 2023

Sorry to inform you that 2b000b1's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@Liyulingyue
Copy link
Contributor Author

@MarioLulab

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work ~
但还有一个单测遗漏了

test/legacy_test/test_identity_loss_op.py Outdated Show resolved Hide resolved
@MarioLulab
Copy link
Contributor

辛苦 pre-commit 一下

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit 5dc7467 into PaddlePaddle:develop Dec 25, 2023
29 checks passed
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
@Liyulingyue Liyulingyue deleted the 109 branch January 15, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants