【PIR API adaptor No.124】 optimizer.Lamb #58881

Liyulingyue · 2023-11-09T13:28:47Z

PR types

Others

PR changes

APIs

Description

test/legacy_test/test_imperative_optimizer_v2.py

@@ -783,6 +784,7 @@ def get_optimizer_dygraph(self, parameter_list):
        )
        return optimizer

+    @test_with_pir_api


test/legacy_test/test_lambv2_op.py

@@ -200,6 +202,7 @@ def test_lamb_op(self):


 class TestLambOpMultiPrecision(unittest.TestCase):
+    @test_with_pir_api


MarioLulab · 2023-11-13T10:41:51Z

还貌似遗漏了 test/legacy_test/test_lamb_op.py 的单测适配？

YuanRisheng

这里新ir并没有适配这个未来会废弃掉的接口，可以尝试修改使用paddle.nn.Linear接口

test/legacy_test/test_lambv2_op.py

test/legacy_test/test_imperative_optimizer_v2.py

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

test/legacy_test/test_imperative_base.py

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

MarioLulab · 2023-11-23T06:24:48Z

需要 pre-commit 一下

paddle-ci-bot · 2023-11-29T03:12:25Z

Sorry to inform you that dce3ec0's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

test/legacy_test/test_lambv2_op.py

MarioLulab · 2023-11-30T02:30:41Z

test/legacy_test/test_lambv2_op.py

fetch_list = [avg_loss]

fetch_list = [loss]

MarioLulab · 2023-11-30T02:31:35Z

test/legacy_test/test_lambv2_op.py

test_lamb_op_with_multi_steps 单测下的所有 base.Program() 麻烦改成 paddle.static.Program()

test/legacy_test/test_imperative_base.py

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

test/legacy_test/test_lambv2_op.py

MarioLulab

nice work~ 但是遇到了不兼容的问题，需要补充到 pr 描述里

MarioLulab · 2023-12-22T07:07:02Z

test/legacy_test/test_lambv2_op.py

@@ -266,6 +270,7 @@ def get_parameter(var):
                np.testing.assert_array_equal(bias_np, get_parameter(bias))
            return weight_np, bias_np

+    @test_with_pir_api


先取消此单测，因为混合精度单测涉及 class OptimizerWithMixedPrecision，该 class 暂不支持 pir 模式。请在 pr 描述里补充说明一下这个情况，并更新单测覆盖率~

test/legacy_test/test_lambv2_op.py

MarioLulab · 2023-12-23T14:20:52Z

需要 pre-commit 一下

test/legacy_test/test_imperative_base.py

MarioLulab

LGTM
lamb 的混合精度单测涉及 class OptimizerWithMixedPrecision，该 class 暂不支持 pir 模式。请在 pr 描述里补充说明一下这个情况，并更新单测覆盖率~

0x45f

辛苦更新下单测覆盖率~

Liyulingyue added 3 commits November 9, 2023 21:20

Update lamb.py

3d7f448

Update test_imperative_optimizer_v2.py

1a0b019

Update test_lambv2_op.py

4724e32

paddle-bot bot added the contributor External developers label Nov 9, 2023

luotao1 mentioned this pull request Nov 10, 2023

新IR Python API适配升级 #58067

Closed

luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 10, 2023

luotao1 assigned luotao1, 0x45f, YuanRisheng and MarioLulab Nov 10, 2023

MarioLulab reviewed Nov 13, 2023

View reviewed changes

Liyulingyue added 2 commits November 15, 2023 08:27

Update test_lambv2_op.py

b3a42fe

Update test_imperative_optimizer_v2.py

16fd450

YuanRisheng reviewed Nov 15, 2023

View reviewed changes

Update test_lambv2_op.py

8489cbc

MarioLulab reviewed Nov 16, 2023

View reviewed changes

test/legacy_test/test_lambv2_op.py Outdated Show resolved Hide resolved

test/legacy_test/test_imperative_optimizer_v2.py

This comment was marked as resolved.

Sign in to view

Liyulingyue and others added 2 commits November 16, 2023 12:37

Update test/legacy_test/test_lambv2_op.py

76a18b0

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

Update test_imperative_base.py

e4f505c

MarioLulab reviewed Nov 20, 2023

View reviewed changes

test/legacy_test/test_imperative_base.py Outdated Show resolved Hide resolved

Update test/legacy_test/test_imperative_base.py

dce3ec0

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

Liyulingyue commented Nov 29, 2023

View reviewed changes

test/legacy_test/test_lambv2_op.py Outdated Show resolved Hide resolved

Apply suggestions from code review

8314858

Liyulingyue requested a review from MarioLulab November 29, 2023 14:12

MarioLulab reviewed Nov 30, 2023

View reviewed changes

Liyulingyue and others added 3 commits December 18, 2023 06:34

Update test/legacy_test/test_imperative_base.py

59c8871

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

Update test_lambv2_op.py

1621e90

Update test_lambv2_op.py

72f9f25

This comment was marked as resolved.

Sign in to view

Update test/legacy_test/test_imperative_optimizer_v2.py

79bf289

Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>

Liyulingyue commented Dec 21, 2023

View reviewed changes

test/legacy_test/test_lambv2_op.py Outdated Show resolved Hide resolved

Apply suggestions from code review

6ba191c

This comment was marked as resolved.

Sign in to view

Update linalg.py

b6fe3e6

MarioLulab reviewed Dec 22, 2023

View reviewed changes

Liyulingyue commented Dec 22, 2023

View reviewed changes

test/legacy_test/test_lambv2_op.py Outdated Show resolved Hide resolved

Apply suggestions from code review

afd5d97

Liyulingyue commented Dec 23, 2023

View reviewed changes

test/legacy_test/test_lambv2_op.py Outdated Show resolved Hide resolved

Apply suggestions from code review

fc9660e

Liyulingyue commented Dec 23, 2023

View reviewed changes

test/legacy_test/test_imperative_base.py Outdated Show resolved Hide resolved

Apply suggestions from code review

c6a223a

MarioLulab approved these changes Dec 25, 2023

View reviewed changes

0x45f approved these changes Dec 25, 2023

View reviewed changes

0x45f merged commit 3969332 into PaddlePaddle:develop Dec 25, 2023
29 checks passed

Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024

【PIR API adaptor No.124】 optimizer.Lamb (PaddlePaddle#58881)

1fe24f0

Liyulingyue deleted the 124 branch January 15, 2024 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【PIR API adaptor No.124】 optimizer.Lamb #58881

【PIR API adaptor No.124】 optimizer.Lamb #58881

Liyulingyue commented Nov 9, 2023

This comment was marked as resolved.

This comment was marked as resolved.

MarioLulab commented Nov 13, 2023

YuanRisheng left a comment

This comment was marked as resolved.

MarioLulab commented Nov 23, 2023

paddle-ci-bot bot commented Nov 29, 2023

This comment was marked as resolved.

This comment was marked as resolved.

MarioLulab Nov 30, 2023

MarioLulab Nov 30, 2023

This comment was marked as resolved.

This comment was marked as resolved.

MarioLulab left a comment

MarioLulab Dec 22, 2023

MarioLulab commented Dec 23, 2023

MarioLulab left a comment

0x45f left a comment

		@@ -200,6 +202,7 @@ def test_lamb_op(self):


		class TestLambOpMultiPrecision(unittest.TestCase):
		@test_with_pir_api

【PIR API adaptor No.124】 optimizer.Lamb #58881

【PIR API adaptor No.124】 optimizer.Lamb #58881

Conversation

Liyulingyue commented Nov 9, 2023

PR types

PR changes

Description

This comment was marked as resolved.

This comment was marked as resolved.

MarioLulab commented Nov 13, 2023

YuanRisheng left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

MarioLulab commented Nov 23, 2023

paddle-ci-bot bot commented Nov 29, 2023

This comment was marked as resolved.

This comment was marked as resolved.

MarioLulab Nov 30, 2023

Choose a reason for hiding this comment

MarioLulab Nov 30, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

MarioLulab left a comment

Choose a reason for hiding this comment

MarioLulab Dec 22, 2023

Choose a reason for hiding this comment

MarioLulab commented Dec 23, 2023

MarioLulab left a comment

Choose a reason for hiding this comment

0x45f left a comment

Choose a reason for hiding this comment