【PIR API adaptor No.158】nanmedian #58889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MarioLulab
reviewed
Nov 13, 2023
There was a problem hiding this comment.
这个文件下遗漏了 TestNanmedianBF16Op 单测的适配
There was a problem hiding this comment.
需要适配一下 x 是 paddle.pir.OpResult 的情况
MarioLulab
reviewed
Nov 15, 2023
Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>
0x45f
reviewed
Nov 15, 2023
python/paddle/tensor/stat.py
Outdated
| @@ -313,8 +313,12 @@ def nanmedian(x, axis=None, keepdim=False, name=None): | |||
| >>> print(y4.numpy()) | |||
| 2.0 | |||
| """ | |||
| if not isinstance(x, Variable): | |||
There was a problem hiding this comment.
这里不用改成ifelse的形式，if not isinstance(x, (Variable, paddle.pir.OpResult)): 就可以~
Co-authored-by: Lu Qi <61354321+MarioLulab@users.noreply.github.com>
MarioLulab
reviewed
Nov 17, 2023
test/legacy_test/test_nanmedian.py
Outdated
| @@ -150,6 +152,7 @@ def test_axis_case(data, axis): | |||
|
|
|||
| paddle.enable_static() | |||
|
|
|||
| @test_with_pir_api | |||
There was a problem hiding this comment.
test_errors 单测可以看一下哪些在 pir 模式下能正常通过，哪些不能正常通过。不能正常通过的关闭 pir 开关，然后在 pr 描述里注明一下跳过了哪些单测
There was a problem hiding this comment.
目前从 ci 来看，nanmedian 得 test_errors 单测暂不支持。辛苦在 pr 描述里写上 “test/legacy_test/test_nanmedian.py 文件里的 TestNanmedian.test_errors ” 单测尚不支持，并更新一下单测覆盖率~
|
Sorry to inform you that 8771d06's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Liyulingyue
commented
Dec 17, 2023
MarioLulab
approved these changes
Dec 18, 2023
0x45f
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
#58067 158