Fix it #58923
Merged
Fix it #58923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@risemeup1 注意一下 |
|
Need to synchronize and modify to here: Line 915 in 4ff3c4d |
gouzil
reviewed
Nov 12, 2023
python/setup.py.in
Outdated
| @@ -912,7 +913,7 @@ with open("@PADDLE_BINARY_DIR@/python/paddle/README.md", "r", encoding='UTF-8') | |||
|
|
|||
| # strip *.so to reduce package size | |||
| if '${WITH_STRIP}' == 'ON': | |||
| command = 'find ${PADDLE_BINARY_DIR}/python/paddle -name "*.so" | xargs -i strip {}' | |||
| command = 'find ${shlex.quote(PADDLE_BINARY_DIR)}/python/paddle -name "*.so" | xargs -i strip {}' | |||
There was a problem hiding this comment.
Suggested change
| command = 'find ${shlex.quote(PADDLE_BINARY_DIR)}/python/paddle -name "*.so" | xargs -i strip {}' | |
| command = ( | |
| 'find ' | |
| + shlex.quote('${PADDLE_BINARY_DIR}') | |
| + '/python/paddle -name "*.so" | xargs -i strip {}' | |
| ) |
Fixed command quoting bug.
risemeup1
approved these changes
Nov 14, 2023
danleifeng
pushed a commit
to danleifeng/Paddle
that referenced
this pull request
Nov 14, 2023
* Quote paddle_binary_dir to prevent command injection. * Quote paddle_binary_dir to prevent command injection. * Update setup.py.in Fixed command quoting bug.
SecretXV
pushed a commit
to SecretXV/Paddle
that referenced
this pull request
Nov 28, 2023
* Quote paddle_binary_dir to prevent command injection. * Quote paddle_binary_dir to prevent command injection. * Update setup.py.in Fixed command quoting bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Use shlex.quote to filter path of paddle binary
Original PR：#52944