Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.146】inner #58931

Merged
merged 5 commits into from Nov 16, 2023
Merged

【PIR API adaptor No.146】inner #58931

merged 5 commits into from Nov 16, 2023

Conversation

cocoshe
Copy link
Contributor

@cocoshe cocoshe commented Nov 12, 2023 •
edited

PR types

Others

PR changes

APIs

Description

[used AI Studio]

No.146 将 paddle.Tensor.inner 迁移升级至 pir，并更新单测 单测覆盖率：1/2
当前1个test_error单测已跳过

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 12, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 12, 2023
@cocoshe cocoshe changed the title 【PIR API adaptor No.146】masked_select 【PIR API adaptor No.146】inner Nov 12, 2023
@luotao1 luotao1 mentioned this pull request Nov 13, 2023
Closed
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 13, 2023
MarioLulab
MarioLulab reviewed Nov 13, 2023
View reviewed changes
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
test/legacy_test/test_inner.py Outdated Show resolved Hide resolved
MarioLulab
MarioLulab approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0x45f
0x45f reviewed Nov 14, 2023
View reviewed changes
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
0x45f
0x45f reviewed Nov 14, 2023
View reviewed changes
python/paddle/tensor/math.py Outdated Show resolved Hide resolved
MarioLulab
MarioLulab approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit c66c543 into PaddlePaddle:develop Nov 16, 2023
28 checks passed
@cocoshe cocoshe mentioned this pull request Nov 24, 2023
Closed
26 tasks
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
@cocoshe @SecretXV
【PIR API adaptor No.146】inner (PaddlePaddle#58931)
0e325ae
@cocoshe cocoshe mentioned this pull request Jan 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

@MarioLulab MarioLulab MarioLulab approved these changes

Assignees

@luotao1 luotao1

@0x45f 0x45f

@YuanRisheng YuanRisheng

@MarioLulab MarioLulab

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cocoshe @0x45f @MarioLulab @luotao1 @YuanRisheng