Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.51、175】 Migrate paddle.vision.ops.decode_jpeg，paddle.vision.ops.read_file into pir #58955

Merged
merged 14 commits into from
Dec 26, 2023
Merged

【PIR API adaptor No.51、175】 Migrate paddle.vision.ops.decode_jpeg，paddle.vision.ops.read_file into pir #58955

merged 14 commits into from
Dec 26, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Nov 13, 2023 •
edited

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
将 paddle.vision.ops.decode_jpeg和paddle.vision.ops.read_file 迁移升级至 pir，并更新单测 单测覆盖率：1/1

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 13, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 13, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 13, 2023
@luotao1 luotao1 mentioned this pull request Nov 14, 2023
Closed
@MarioLulab
Copy link
Contributor

MarioLulab commented Nov 21, 2023 •
edited

read_file op 需要迁移到 PHI 体系下，内部已经记录该问题。这个 pr 可以先搁置

@enkilee
Copy link
Contributor Author

enkilee commented Nov 21, 2023

收到

@paddle-ci-bot Paddle-ci-bot
Copy link

paddle-ci-bot bot commented Nov 29, 2023

Sorry to inform you that 9ad3f7f's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@MarioLulab
Copy link
Contributor

MarioLulab commented Dec 18, 2023 •
edited

read_file op 已迁移至 phi 体系下。可以关注这个 pr: #60126 该 pr 添加 read_file op 的配置文件，以生成 read_file op 的 pir 组网 api，待这个 pr 合入后，当前 pr 就可以继续推进了~
还有我看到 read_file op 和 decode_jpeg op 的单测是关联的，敏师傅可以顺便认领一下 51 号子任务（decode_jpeg 的 pir 适配），然后顺便在当前 pr 一起做掉吧 😄 🚀

@enkilee enkilee changed the title 【PIR API adaptor No.175】 Migrate paddle.vision.ops.read_file into pir 【PIR API adaptor No.51、175】 Migrate paddle.vision.ops.decode_jpeg，paddle.vision.ops.read_file into pir Dec 19, 2023
0x45f
0x45f reviewed Dec 20, 2023
View reviewed changes
test/legacy_test/test_read_file.py Outdated
@@ -36,35 +38,47 @@ def tearDown(self):
def read_file_decode_jpeg(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数改成test_开头吧，不然单测不会执行，也就导致覆盖率的ci没有过~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

test/legacy_test/test_read_file.py Outdated Show resolved Hide resolved
MarioLulab
MarioLulab suggested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

关于 read_file api，还需要修改 read_file op 的 infermeta 函数及 read_file api 的 pir 分支，具体可以参考：#60242 .
#60242 应该没法合入因为覆盖率会不通过。敏师傅在当前 pr 做修改吧

test/legacy_test/test_read_file.py Outdated

def test_read_file_decode_jpeg_dynamic(self):
self.read_file_decode_jpeg()
class TestReadFileWithStatic(unittest.TestLoader):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class TestReadFileWithStatic(unittest.TestLoader):
class TestReadFileWithStatic(unittest.TestCase):

设置错了的话单测不会运行，导致 ci-coverage 不通过

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

收到

@MarioLulab
Copy link
Contributor

MarioLulab commented Dec 22, 2023 •
edited

当前 pr 可以按照 #60242 修改一下 read_file python api 和 nullary.cc。这个 pr 直接在 read_file op 的 infermeta 里设置 output tensor 的 dtype 为 uint8，这样能保持 pir 与旧 ir 的组网行为一致
我本地测过了没问题，辛苦修改一下吧~ @enkilee

@enkilee
Copy link
Contributor Author

enkilee commented Dec 25, 2023

当前 pr 可以按照 #60242 修改一下 read_file python api 和 nullary.cc。这个 pr 直接在 read_file op 的 infermeta 里设置 output tensor 的 dtype 为 uint8，这样能保持 pir 与旧 ir 的组网行为一致 我本地测过了没问题，辛苦修改一下吧~ @enkilee

收到，谢谢

MarioLulab
MarioLulab approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarioLulab MarioLulab mentioned this pull request Dec 26, 2023
Merged
@0x45f 0x45f merged commit 868f2a8 into PaddlePaddle:develop Dec 26, 2023
29 checks passed
@MarioLulab MarioLulab mentioned this pull request Dec 26, 2023
Closed
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
@enkilee
【PIR API adaptor No.51、175】 Migrate paddle.vision.ops.decode_jpeg，pad…
942c4d2 
…dle.vision.ops.read_file into pir (PaddlePaddle#58955)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x45f 0x45f 0x45f approved these changes

@MarioLulab MarioLulab MarioLulab approved these changes

Assignees

@luotao1 luotao1

@0x45f 0x45f

@YuanRisheng YuanRisheng

@MarioLulab MarioLulab

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enkilee @MarioLulab @0x45f @luotao1 @YuanRisheng