Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on GCC 13 and Linux 6.0+ #59078

Merged
merged 3 commits into from Nov 20, 2023
Merged

Conversation

gumblex
Copy link
Contributor

@gumblex gumblex commented Nov 16, 2023

PR types

Bug fixes

PR changes

Others

Description

  1. GCC 13 breaking changes require <cstdint> header explicitly included.
  2. Third-party dependency gloo can't compile on Linux 6.0+, for header changes. This add an upstream patch.

Copy link

paddle-bot bot commented Nov 16, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 16, 2023
risemeup1
risemeup1 previously approved these changes Nov 17, 2023
@luotao1
Copy link
Contributor

luotao1 commented Nov 17, 2023

请根据 PR-CI-Codestyle-Check 提示,安装下 precommit,修一下格式问题,谢谢!

@luotao1 luotao1 merged commit e2517d1 into PaddlePaddle:develop Nov 20, 2023
28 checks passed
@luotao1
Copy link
Contributor

luotao1 commented Nov 20, 2023

hi, @gumblex

  • 非常感谢你对飞桨框架的贡献,我们正在运营一个PFCC组织,会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献,详情可见 https://github.com/luotao1 主页说明。
  • 如果你对PFCC有兴趣,请发送邮件至 ext_paddle_oss@baidu.com,我们会邀请你加入~

SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
* fix <cstdint> header for GCC 13, fix gloo for linux 6.0+

* fix code style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants