Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoParallel] convert disttensor for pylayer #59148

Conversation

wanghuancoder
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Pylayer,如果有1个Tensor为DistTensor,则全部转换为DistTensor
Pcard-73145

Copy link

paddle-bot bot commented Nov 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@GhostScreaming
Copy link
Contributor

欢哥,文件里面还有一个GetTensorsFromPyObject,看了一下是用来处理ctx里not_inplace_tensorsnon_differentiable的Tensor,这个需要支持dist_tensor吗

@wanghuancoder
Copy link
Contributor Author

欢哥,文件里面还有一个GetTensorsFromPyObject,看了一下是用来处理ctx里not_inplace_tensorsnon_differentiable的Tensor,这个需要支持dist_tensor吗

哦,这两个应该是不用的。这两个是用于用户标记forward的返回值得处理策略的:

  1. 如果是AutoParallel,返回值就已经是DistTensor了
  2. 而且这个标记不作为PHI计算使用。是通过标记中的指针和forward的返回值的指针做匹配用的~

Copy link
Contributor

@GhostScreaming GhostScreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GhostScreaming GhostScreaming merged commit 831137c into PaddlePaddle:develop Nov 21, 2023
28 checks passed
SecretXV pushed a commit to SecretXV/Paddle that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants