[AutoParallel] Add reduce_all spmd rule #59411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
| // NOTE(zhonghui): There is no reduce_all type of ncclRedOp_t, just use | ||
| // min to replace | ||
| red_type = ncclMin; | ||
| break; | ||
| } |
There was a problem hiding this comment.
对的，从partial转换到replicate状态的时候，需要调用allReduce算子，无论是nccl还是gloo，都没有reduce_all这个type，只有sum、mean、max、min、prod这几种。这里用min来模拟bool类型的reduce_all操作，得到的结果是相同的。
| opts->setReduceFunction( | ||
| static_cast<void (*)(void*, const void*, const void*, size_t)>( | ||
| &gloo::min<T>)); | ||
| break; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
添加对reduce_all算子切分推导规则的支持、添加相关的单元测试
Pcard-73145