Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.308】Migrate Paddle.tensor.tensordot into pir #59459

Closed

Conversation

Olive-2019
Copy link

@Olive-2019 Olive-2019 commented Nov 28, 2023

PR types

Others

PR changes

APIs

Description

#58067
PIR API 推全升级
将算子迁移升级至 pir,并更新单测
Paddle.tensor.tensordot(9/9)

Copy link

paddle-bot bot commented Nov 28, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 28, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 29, 2023
@@ -4669,7 +4669,7 @@ def tensordot(x, y, axes=2, name=None):
check_type(axes, 'axes', (int, tuple, list, Variable), op_type)
Copy link
Contributor

@MarioLulab MarioLulab Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
check_type(axes, 'axes', (int, tuple, list, Variable), op_type)
check_type(axes, 'axes', (int, tuple, list, Variable, paddle.pir.Value), op_type)

This comment was marked as abuse.

@MarioLulab
Copy link
Contributor

MarioLulab commented Dec 12, 2023

请问大佬这个 pr 最近还有空推进吗 ~ 没有的话可以让内部研发接着做啦😃

@Olive-2019
Copy link
Author

请问大佬这个 pr 最近还有空推进吗 ~ 没有的话可以让内部研发接着做啦😃
抱歉抱歉,最近期末事情太多了,可能没空推进了

@MarioLulab
Copy link
Contributor

请问大佬这个 pr 最近还有空推进吗 ~ 没有的话可以让内部研发接着做啦😃
抱歉抱歉,最近期末事情太多了,可能没空推进了

好的没事~ 那我们就在你的代码上继续推进啦 🚀

@MarioLulab
Copy link
Contributor

Done in #60014.
欢迎下次贡献~

@MarioLulab MarioLulab closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants