【PIR API adaptor No.284, 293】 Migrate paddle.Tensor.nanquantile and paddle.Tensor.quantile into pir #59572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MarioLulab
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
LGTM~
可以在 pr 描述里写一下：
- nanquantile 在
test/legacy_test/test_zero_dim_tensor.py里的 test_nanquantile 单测暂不支持。因为 paddle.static.append_backward 尚未支持 pir 模式 - quantile 在
test/legacy_test/test_zero_dim_tensor.py里的 TestSundryAPIStatic.test_quantile 单测暂不支持。因为 paddle.static.append_backward 尚未支持 pir 模式
然后分别更新一下 nanquantile 和 quantile 的单测覆盖率
已修改，感谢~ |
|
代码冲突了，辛苦解决下冲突~ |
xiaoyewww
force-pushed
the
new-ir/quantile_and_nanquantile
branch
from
d2c6716
to
8d28aad
Compare
不好意思之前忘记了，已解决冲突，麻烦再review一下~ |
MarioLulab
reviewed
Dec 8, 2023
0x45f
reviewed
Dec 11, 2023
0x45f
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
#58067
No.284 将 paddle.Tensor.nanquantile迁移升级至 pir，并更新单测，单测覆盖率：1/2。
nanquantile 在 test/legacy_test/test_zero_dim_tensor.py 里的 test_nanquantile 单测暂不支持。因为 paddle.static.append_backward 尚未支持 pir 模式
No.293 将 paddle.Tensor.quantile迁移升级至 pir，并更新单测，单测覆盖率：1/2。
quantile 在 test/legacy_test/test_zero_dim_tensor.py 里的 TestSundryAPIStatic.test_quantile 单测暂不支持。因为 paddle.static.append_backward 尚未支持 pir 模式