[PIR]add build cinn pass constrain #59759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
phlrain
changed the title
Aurelius84
approved these changes
Dec 8, 2023
| out.first_use().owner()->isa<paddle::dialect::UniformOp>()) { | ||
| return true; | ||
| if (out.use_count() > 0) { | ||
| return !IsSupportCinn(out.first_use().owner()); |
There was a problem hiding this comment.
这个意味着 Full 的输出如果传递给了一个CINN不支持的算子，则full本身单算子不会交给CINN来生成kernel？
There was a problem hiding this comment.
是的， 这个逻辑后面会跟build cinn pass 统一优化下
| @@ -162,6 +204,9 @@ bool IsSupportCinn(pir::Operation* op) { | |||
|
|
|||
| // Strip the dialect, like pd_op.abs -> abs | |||
| const auto op_name = CompatibleInfo::OpName(*op); | |||
| if (op_name == "matmul") { | |||
There was a problem hiding this comment.
类似这样的名单更推荐添加到 line 110行中的 OpTransInfo.default_deny_ops_里，统一管理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
添加build cinn pass的检查，对于cinn不支持的算子，不做映射
Pcard-67164