-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR API adaptor No.95】Migrate nn.functional.grid_sample into pir #59861
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
graph_sample_neighbors 算子需要配置对应的 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
还有一些问题,辛苦修改一下~
@@ -45,6 +46,7 @@ def setUp(self): | |||
self.x = np.random.randn(*(self.x_shape)).astype(self.dtype) | |||
self.grid = np.random.uniform(-1, 1, self.grid_shape).astype(self.dtype) | |||
|
|||
@test_with_pir_api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@test_with_pir_api
装饰器不应该装饰 static_functional
,应该用来修饰 _test_equivalence
单测,因为 _test_equivalence
才是实际用来作比较的
麻烦修改 pr 标题为:【PIR API adaptor No.95】Migrate nn.functional.grid_sample into pir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
APIs
Description
PIR API 推全升级
将如下算子迁移升级至 pir,并更新单测