Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.95】Migrate nn.functional.grid_sample into pir #59861

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

longranger2
Copy link
Contributor

@longranger2 longranger2 commented Dec 9, 2023

PR types

Others

PR changes

APIs

Description

PIR API 推全升级
将如下算子迁移升级至 pir,并更新单测

  1. graph_sample_neighbors:暂不迁移
  2. sample_neighbors:暂不迁移
  3. grid_sample:(18/18)

Copy link

paddle-bot bot commented Dec 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Dec 9, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 11, 2023
@MarioLulab
Copy link
Contributor

graph_sample_neighbors 算子需要配置对应的 paddle/fluid/pir/dialect/operator/ir/ops.yaml ,以生成 pd_op 定义和 C++ API。本次与 graph_sample_neighbors 算子对应的 sample_neighborsgraph_sample_neighbors api 可以先不迁移。麻烦修改一下 pr 标题和 pr 描述吧~

@longranger2
Copy link
Contributor Author

done

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work
还有一些问题,辛苦修改一下~

@@ -45,6 +46,7 @@ def setUp(self):
self.x = np.random.randn(*(self.x_shape)).astype(self.dtype)
self.grid = np.random.uniform(-1, 1, self.grid_shape).astype(self.dtype)

@test_with_pir_api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@test_with_pir_api 装饰器不应该装饰 static_functional,应该用来修饰 _test_equivalence 单测,因为 _test_equivalence 才是实际用来作比较的

@MarioLulab
Copy link
Contributor

麻烦修改 pr 标题为:【PIR API adaptor No.95】Migrate nn.functional.grid_sample into pir

Copy link
Contributor

@MarioLulab MarioLulab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longranger2 longranger2 changed the title 【PIR API adaptor No.93-95】Migrate some ops into pir 【PIR API adaptor No.95】Migrate nn.functional.grid_sample into pir Dec 14, 2023
@0x45f 0x45f merged commit cecb932 into PaddlePaddle:develop Dec 15, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants