Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【PIR API adaptor No.287】 Migrate npair_loss to pir #60199

Merged
merged 2 commits into from
Dec 22, 2023
Merged

【PIR API adaptor No.287】 Migrate npair_loss to pir #60199

merged 2 commits into from
Dec 22, 2023

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Dec 20, 2023 •
edited

PR types

Others

PR changes

Others

Description

任务 issue: #58067
静态图相关单测已经全部适配
Pcard-67164

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Dec 20, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@0x45f 0x45f changed the title [PIR]Migrate npair_loss to pir 【PIR API adaptor No.287】 Migrate npair_loss to pir Dec 21, 2023
@luotao1 luotao1 mentioned this pull request Dec 21, 2023
Closed
Aurelius84
Aurelius84 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

changeyoung98
changeyoung98 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@changeyoung98 changeyoung98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f merged commit c38cf07 into PaddlePaddle:develop Dec 22, 2023
29 checks passed
@0x45f 0x45f deleted the pir-npair-loss branch December 22, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@changeyoung98 changeyoung98 changeyoung98 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0x45f @Aurelius84 @changeyoung98 @YuanRisheng