Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR API adaptor No.300、305、306】Migrate SigmoidTransform、StackTransform、StickBreakingTransform into pir #60325

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

changeyoung98
Copy link
Contributor

PR types

Others

PR changes

APIs

Description

pcard-67164
PIR API 推全升级
将 python/paddle/distribution/transform.py 迁移升级至 pir,并更新单测

paddle.distribution.SigmoidTransform
paddle.distribution.StackTransform
paddle.distribution.StickBreakingTransform

单测覆盖率:all

Copy link

paddle-bot bot commented Dec 25, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@0x45f
Copy link
Contributor

0x45f commented Dec 26, 2023

我看还有一个test/distribution/test_distribution_transform_static.py文件,这里面有需要适配的单测嘛

Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要适配的单测不应该是test_distribution_transform_static.py吗

@YuanRisheng
Copy link
Contributor

分布式单测有一套自己的单测生成装饰器,为了减少单测适配工作量,需要对装饰器适配pir,可以参考这个pr里分布式单测适配一下pir:#60345

@changeyoung98
Copy link
Contributor Author

test_distribution_transform_static.py里面没有这几个transform子类的测试,我就直接把测试加在了之前动态图测试的文件里。感觉可以直接把我加的那些静态图测试移到static下就可以了?

@changeyoung98 changeyoung98 merged commit bc60ffa into PaddlePaddle:develop Dec 27, 2023
29 checks passed
@changeyoung98 changeyoung98 deleted the czy-transform branch December 27, 2023 08:26
Wanglongzhi2001 pushed a commit to Wanglongzhi2001/Paddle that referenced this pull request Jan 7, 2024
…rm、StickBreakingTransform into pir (PaddlePaddle#60325)

* SigmoidTransform pir passed

* StackTransform and StickBreakingTransform pir passed

* move tests to _static.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants