【PIR API adaptor No.182】Migrate paddle.optimizer.RMSProp into pir #60350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
|
RMSProp 依赖于 DataFeeder ，但目前 DataFeeder 还没有适配 pir 模式，这个我正在适配，有进展了我会在这个 pr 下及时 comment~ |
|
对 DataFeeder 的适配在 #60434 中已完成。可以继续推进当前 pr 的合入了~ |
|
Sorry to inform you that ce60485's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
请问 o 师傅最近还有时间来推进这个 pr 吗？如果没空的话就由我来推进吧 😃 ？ |
有时间～ |
|
有个地方会报错 test_main的时候 1543: Traceback (most recent call last):
1543: File "/paddle/build/test/legacy_test/test_rmsprop_op.py", line 580, in test_main
1543: output1_pir = self.pir_rmsprop_mp(use_amp=True, mp=True)
1543: File "/paddle/build/test/legacy_test/test_rmsprop_op.py", line 529, in pir_rmsprop_mp
1543: optimizer.minimize(loss)
1543: File "/paddle/build/python/paddle/static/amp/decorator.py", line 668, in minimize
1543: scaled_params_grads = self.backward(
1543: File "/paddle/build/python/paddle/static/amp/decorator.py", line 231, in backward
1543: with program_guard(self._train_program, startup_program):
1543: File "/usr/lib/python3.9/contextlib.py", line 119, in __enter__
1543: return next(self.gen)
1543: File "/paddle/build/python/paddle/base/framework.py", line 7863, in program_guard
1543: check_type(
1543: File "/paddle/build/python/paddle/base/data_feeder.py", line 203, in check_type
1543: raise TypeError(
1543: TypeError: The type of 'main_program' in paddle.static.program_guard must be <class 'paddle.base.framework.Program'>, but received <class 'paddle.base.libpaddle.pir.Program'> |
0x45f
reviewed
Jan 11, 2024
0x45f
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Description
link #58067
PIR API 推全升级
将 paddle.optimizer.RMSProp 迁移升级至 pir，并更新单测
单测覆盖率: 3/6