-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PIR API adaptor No.171】Migrate paddle.vision.ops.PSRoIPool into pir #60353
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestPSROIPoolStaticAPI 单测的输入 self.boxes_placeholder 仍然有 lod_level 。但目前 pir 模式暂不支持 lod 输入,可以考虑在 test/legacy_test/test_psroi_pool_op.py
文件下新增一个 pir 单测
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -397,5 +397,49 @@ def test_function_in_static(self): | |||
np.testing.assert_allclose(out_res, expect_out, rtol=1e-05) | |||
|
|||
|
|||
class TestPSROIPoolStaticAPI_NOLOD(unittest.TestCase): | |||
def setUp(self): | |||
paddle.enable_static() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在测试case里用了IrGuard是不是不需要手动切到静态图了?在setUp里切到静态图可能会影响后续单测运行时的模式,这里删掉 paddle.enable_static() 试试呢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好嘟~
Sorry to inform you that a0f04ee's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o 师傅最近还有时间来推进这个 pr 吗~
|
PR types
Others
PR changes
APIs
Description
link #58067
PIR API 推全升级
将 paddle.vision.ops.PSRoIPool 迁移升级至 pir,并更新单测
单测覆盖率: 1/8
继承自optest的单侧未开启,暂不支持 lod操作