Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PIR Dist Op Reg No.2】 reg distributed_push_sparse #60805

Merged
merged 24 commits into from
Mar 15, 2024

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 15, 2024

PR types

Others

PR changes

Others

Description

Copy link

paddle-bot bot commented Jan 15, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 15, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 15, 2024
Copy link
Contributor

@xingmingyyj xingmingyyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议补充一下单测
现在op注册时的output名称是output

  output : Tensor[](output){ids.size()}

但是op_compat里面的配置是out,

- op : distributed_push_sparse
  inputs :
    {ids : Ids, shows : Shows, clicks: Clicks}
  outputs :
    out : Outputs

可以设置一下单测,确认一下能不能正确翻译

@kangguangli kangguangli requested a review from zyfncg March 15, 2024 03:04
if (out == nullptr) {
continue;
}
out->set_dtype(ids[0]->dtype());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个output不需要设置dim信息吗?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个output不需要设置dim信息吗?

原本的InferShape里并没有相关代码,这类Op一般是通过pass插入,不是正常组网得到的,我觉得还是不加为好。

@kangguangli kangguangli requested a review from zyfncg March 15, 2024 07:59
@kangguangli kangguangli merged commit 2719245 into PaddlePaddle:develop Mar 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants