[CINN] Add pass for broadcast tree to condition op in dynamic shape #60828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… broadcast_tree_to_cond_op
… broadcast_tree_to_cond_op
output_types of JitKernelOp come from compiled data.
… broadcast_tree_to_cond_op
…into broadcast_tree_to_cond_op
zhangbo9674
previously approved these changes
Jan 22, 2024
Comment on lines
58
to
61
| VLOG(4) << "Run func_args_ size: " << func_args_.size(); | ||
| for (const auto& args : func_args_) { | ||
| VLOG(4) << " args type_code: " << args.type_code(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| VLOG(4) << "Run func_args_ size: " << func_args_.size(); | |
| for (const auto& args : func_args_) { | |
| VLOG(4) << " args type_code: " << args.type_code(); | |
| } | |
| if (VLOG_IS_ON(4)) { | |
| VLOG(4) << "Run func_args_ size: " << func_args_.size(); | |
| for (const auto& args : func_args_) { | |
| VLOG(4) << " args type_code: " << args.type_code(); | |
| } | |
| } |
| @@ -88,6 +91,11 @@ class CinnJitInstruction::FnPtrImpl { | |||
| sizeof(int32_t*))); | |||
| } | |||
|
|
|||
| VLOG(4) << "InferShape func_args_ size: " << func_args_.size(); | |||
jiahy0825
reviewed
Jan 22, 2024
| std::ostream& operator<<(std::ostream& os, const BroadcastTree& tree); | ||
|
|
||
| } // namespace cinn::common |
There was a problem hiding this comment.
BroadcastTree有多个构造接口，与其他输出流重载函数会出现编译冲突
| } | ||
|
|
||
| std::vector<::pir::Value> output_values; | ||
| for (auto* op : this->ops) { |
There was a problem hiding this comment.
返回值 output_values 是个 vector，，这里似乎要从 group_ops_set 里面遍历，否则 output_values 里面可能有重复值
There was a problem hiding this comment.
ops带有图的拓扑结构，理论上不会出现重复op
… broadcast_tree_to_cond_op
… broadcast_tree_to_cond_op
zhangbo9674
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-73448
Add pass for broadcast tree to condition op in dynamic shape.