【PIR Dist Op Reg No.24】 reg distributed_lookup_table #60911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
xiaoyewww
force-pushed
the
pir/distributed_lookup_table
branch
from
087bb2c
to
8fd466e
Compare
Closed
xiaoyewww
force-pushed
the
pir/distributed_lookup_table
branch
from
8fd466e
to
5a51ebd
Compare
xiaoyewww
force-pushed
the
pir/distributed_lookup_table
branch
from
5a51ebd
to
fe1c840
Compare
kangguangli
reviewed
Jan 22, 2024
|
|
||
| import unittest | ||
|
|
||
| import test_op_transcriber |
There was a problem hiding this comment.
Suggested change
| import test_op_transcriber | |
| import test_op_translator |
There was a problem hiding this comment.
感谢～已修改，麻烦再review一下～
xiaoyewww
force-pushed
the
pir/distributed_lookup_table
branch
from
795e695
to
bbefc1b
Compare
kangguangli
reviewed
Jan 23, 2024
| func : DistributeLookupTableInferMeta | ||
| kernel : | ||
| func : distributed_lookup_table | ||
| data_type : ids |
There was a problem hiding this comment.
Suggested change
| data_type : ids | |
| data_type : dtype |
这里需要和DistributedLookupTableOp::GetExpectedKernelType 保持一致
| @@ -374,6 +374,15 @@ | |||
| data_type : fpn_rois | |||
| optional : rois_num, multi_level_rois_num | |||
|
|
|||
| - op : distributed_lookup_table | |||
| args : (Tensor[] ids, Tensor w, int table_id = 0, bool is_distributed = false, str lookup_table_version = "lookup_table", int64_t padding_idx = -1, int dtype = 5, bool is_test = false) | |||
There was a problem hiding this comment.
Suggested change
| args : (Tensor[] ids, Tensor w, int table_id = 0, bool is_distributed = false, str lookup_table_version = "lookup_table", int64_t padding_idx = -1, int dtype = 5, bool is_test = false) | |
| args : (Tensor[] ids, Tensor w, int table_id = 0, bool is_distributed = false, str lookup_table_version = "lookup_table", int64_t padding_idx = -1, DataType dtype = DataType::FLOAT32, bool is_test = false) |
paddle/phi/infermeta/binary.cc
Outdated
| bool is_distributed, | ||
| const std::string& lookup_table_version, | ||
| int64_t padding_idx, | ||
| int dtype, |
There was a problem hiding this comment.
Suggested change
| int dtype, | |
| DataType dtype, |
xiaoyewww
force-pushed
the
pir/distributed_lookup_table
branch
from
485650b
to
8be548c
Compare
xiaoyewww
force-pushed
the
pir/distributed_lookup_table
branch
from
8be548c
to
d0a8e3c
Compare
|
可以rerun一下CI,应该可以合入了 |
rerun后CI全过了，麻烦approve一下，感谢～ |
kangguangli
approved these changes
Jan 25, 2024
zyfncg
approved these changes
Jan 25, 2024
| @@ -0,0 +1,56 @@ | |||
| # Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
#60436
注册算子distributed_lookup_table