Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR]Fix array_write stop_gradient #60970

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

changeyoung98
Copy link
Contributor

@changeyoung98 changeyoung98 commented Jan 19, 2024

PR types

Others

PR changes

Others

Description

pcard-67164
Fix array_write stop_gradient

  • 删除对 PassStopGradientsDefaultly 的调用,对array_write前两个参数的stop_gradient值取 && 操作,赋给第一个参数。
  • 删除test_assign_op中对stop_gradient的显式设置。
  • test_dynamic_rnn_stop_gradient.py 中stop_gradient设置还有问题,todo

Copy link

paddle-bot bot commented Jan 19, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changeyoung98 changeyoung98 merged commit 4db394f into PaddlePaddle:develop Jan 22, 2024
29 checks passed
@changeyoung98 changeyoung98 deleted the czy-stopgradient branch January 23, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants