【pir】modify test_case.py #60976
Merged
【pir】modify test_case.py #60976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
reviewed
Jan 22, 2024
| true_block.size(), | ||
| 0u, | ||
| phi::errors::PreconditionNotMet( | ||
| "The true block must have at least one op yield op.")); |
There was a problem hiding this comment.
Suggested change
| "The true block must have at least one op yield op.")); | |
| "The true block must have at least one op (inlcuding yield op).")); |
| false_block.size(), | ||
| 0u, | ||
| phi::errors::PreconditionNotMet( | ||
| "The false block must have at least one op yield op.")); |
There was a problem hiding this comment.
Suggested change
| "The false block must have at least one op yield op.")); | |
| "The false block must have at least one op(including yield op).")); |
| (sub block nest should Add on demand to aviod block copy) | ||
| ''' | ||
| total_ops = [] | ||
| if block.parent_block is not None: |
There was a problem hiding this comment.
这里 total 的语义是只包括入参block的父亲和祖父 block？
There was a problem hiding this comment.
理论上是所有的祖block ,但是为了避免使用while,造成block 的拷贝，只限制了两层
zhangbo9674
reviewed
Jan 22, 2024
| (*this)->region(0).size())); | ||
| if ((*this)->region(1).front().size() > 0) { | ||
| auto &false_last_op = (*this)->region(1).front().back(); | ||
| VLOG(4) << "Start Verifying false branch."; |
There was a problem hiding this comment.
false branch 的 verify 建议放在最上面的 if ((*this)->num_results() != 0) 分支语句之外，因为我们要求 if 分支不能只有一个分支，现在的逻辑下，如果 num_results == 0，这个要求就检查不到了
There was a problem hiding this comment.
这个功能是为了在num_results= 0 的时候跳过检查，允许if 无yield op
zhangbo9674
approved these changes
Jan 22, 2024
Aurelius84
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
others
PR changes
others
Description
pcard-67164
修复子block 中调用append_backward的样例