[PIR] pir onednn add conv_bias_pass #61137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… pir_onednn_conv_bias_pass
… pir_onednn_conv_bias_pass
yuanlehome
reviewed
Jan 29, 2024
| def setUp(self): | ||
| self.places.append(paddle.CPUPlace()) | ||
| # todo(bukejiyu): This pass will support accuracy verification in the future | ||
| self.skip_accuracy_verification = True |
There was a problem hiding this comment.
我抄的别人的，这里关掉。我以为全关掉呢。我给打开了。
yuanlehome
reviewed
Jan 29, 2024
| @@ -0,0 +1,167 @@ | |||
| # Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. | |||
yuanlehome
reviewed
Jan 29, 2024
| add_custom_command( | ||
| OUTPUT ${onednn_op_creator_file} | ||
| COMMAND | ||
| ${PYTHON_EXECUTABLE} ${op_creator_gen_file} --op_yaml_files |
There was a problem hiding this comment.
onednn op的创建也需要op_yaml_files吗？这里的逻辑和53-69行的逻辑是不是在创建pd op的部分重复了？
There was a problem hiding this comment.
onednn op的创建也需要op_yaml_files。因为ops_onednn_extra.yaml中只有补充信息，主要的OP信息还是在原来的ops.yaml中，需要复用。
yuanlehome
reviewed
Jan 29, 2024
| pat.Tensor("add_out") = add(pat.Tensor("conv2d_out"), pat.Tensor("bias")); | ||
|
|
||
| pat.RequireNativeCall([&](const paddle::drr::MatchContext &match_ctx) { | ||
| std::set<std::string> padding_algorithm = {"EXPLICIT", "SAME", "VALID"}; |
There was a problem hiding this comment.
unordered_set或者vector是不是就可以？
There was a problem hiding this comment.
我觉得，这里还是set最适合。
yuanlehome
reviewed
Jan 29, 2024
Comment on lines
+117
to
+118
| std::set<std::string> padding_algorithm = {"EXPLICIT", "SAME", "VALID"}; | ||
| std::set<std::string> data_format = {"NCHW", "NHWC", "AnyLayout"}; |
zhangbo9674
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-67164
PIR-OneDNN的首个Pass。
建立相关机制。完成conv2d_bias_fuse_pass的开发和测试。
conv2d_bias_fuse_pass等同于老静态图中的paddle/fluid/framework/ir/mkldnn/conv_bias_mkldnn_fuse_pass.cc里的conv_bias_mkldnn_fuse_pass。