【PIR Dist Op Reg No.25】 reg distributed_fused_lamb_init #62050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
luotao1
changed the title
kangguangli
reviewed
Feb 26, 2024
好的，我这里后续加一下，aistudio上一直在第三方库上没编译成功。。。我有空编译好了添加一下 |
xiaoyewww
force-pushed
the
feat/distributed_fused_lamb_init
branch
from
0e65734
to
583af04
Compare
kangguangli
reviewed
Feb 29, 2024
kangguangli
reviewed
Mar 1, 2024
|
@kangguangli ci通过了，麻烦review一下~ |
kangguangli
previously approved these changes
Mar 4, 2024
zyfncg
reviewed
Mar 4, 2024
| std::vector<MetaTensor*> grad_out, | ||
| MetaTensor* global_scale, | ||
| MetaTensor* step) { | ||
| fp32_fused_param->set_dtype(DataType::FLOAT32); |
There was a problem hiding this comment.
旧IR下该算子的InferShape为空，这些是他新增的。如果要新增dims的话，只能根据kernel的实现去推测，感觉可以等后续对InferMeta有需要再完善，这里我觉得保持现状较好。
| @@ -0,0 +1,152 @@ | |||
| # Copyright (c) 2023 PaddlePaddle Authors. All Rights Reserved. | |||
xiaoyewww
force-pushed
the
feat/distributed_fused_lamb_init
branch
from
90dc536
to
a86d558
Compare
zyfncg
previously approved these changes
Mar 4, 2024
xiaoyewww
force-pushed
the
feat/distributed_fused_lamb_init
branch
from
a86d558
to
474f1a3
Compare
kangguangli
approved these changes
Mar 5, 2024
zyfncg
approved these changes
Mar 5, 2024
jeff41404
approved these changes
Mar 5, 2024
|
@jzhang533 @sunzhongkai588 @Ligoml |
xiaoyewww
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
#60436
注册算子distributed_fused_lamb_init