【PIR Dist Op Reg No.14】reg_pir_send_and_recv #62589
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Difers
changed the title
Closed
|
Sorry to inform you that 304be96's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Difers
force-pushed
the
reg_pir_send_recv
branch
2 times, most recently
from
0d6efa4
to
726e361
Compare
xingmingyyj
reviewed
Mar 28, 2024
| @@ -1483,6 +1483,17 @@ | |||
| kernel: | |||
| func: seed | |||
|
|
|||
| - op : send_and_recv | |||
| args : (Tensor x, str message_name, str[] send_var_name, str[] recv_var_name, int trainer_id = 0, str mode="forward", str[] endpoints={"127.0.0.1:6164"}, str[] next_endpoints={"127.0.0.1:6164"}, str[] previous_endpoints={"127.0.0.1:6164"}) | |||
There was a problem hiding this comment.
这里的x和out根据旧IR下的定义
void Make() override {
AddInput("X", "Tensor Input variable to be sent").AsDuplicable();
AddOutput("Out", "Tensor Output variable to be recv").AsDuplicable();应该收Tensor[]类型。
Difers
force-pushed
the
reg_pir_send_recv
branch
from
726e361
to
cfd8beb
Compare
|
需要解决下冲突 |
xingmingyyj
reviewed
Apr 22, 2024
| @@ -1505,6 +1505,17 @@ | |||
| kernel: | |||
| func: seed | |||
|
|
|||
| - op : send_and_recv | |||
| args : (Tensor[] x, str message_name, str[] send_var_name, str[] recv_var_name, int trainer_id = 0, str mode="forward", str[] endpoints={"127.0.0.1:6164"}, str[] next_endpoints={"127.0.0.1:6164"}, str[] previous_endpoints={"127.0.0.1:6164"}) | |||
| output : Tensor[](out) | |||
There was a problem hiding this comment.
Suggested change
| output : Tensor[](out) | |
| output : Tensor[](out){x.size()} |
这里需要加上{x.size()},代码生成脚本如果发现没有x.size()会使用None填充，导致编译错误
| args : (Tensor[] x, str message_name, str[] send_var_name, str[] recv_var_name, int trainer_id = 0, str mode="forward", str[] endpoints={"127.0.0.1:6164"}, str[] next_endpoints={"127.0.0.1:6164"}, str[] previous_endpoints={"127.0.0.1:6164"}) | ||
| output : Tensor[](out) | ||
| infer_meta : | ||
| func : UnchangedInferMeta |
There was a problem hiding this comment.
Suggested change
| func : UnchangedInferMeta | |
| func : UnchangedVectorInferMeta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description