【PIR Dist Op Reg No.11】 reg dgc_momentum #63013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
kangguangli
reviewed
Mar 26, 2024
| kernel : | ||
| func : dgc_momentum | ||
| data_type : param | ||
| backward : divide_grad |
There was a problem hiding this comment.
Suggested change
| backward : divide_grad |
是否忘记删除了
kangguangli
reviewed
Mar 27, 2024
paddle/phi/api/yaml/op_compat.yaml
Outdated
| @@ -818,6 +818,12 @@ | |||
| outputs : | |||
| out : Out | |||
|
|
|||
| - op : dgc_momentum | |||
| inputs : | |||
| {param : Param, grad : Grad, velocity : Velocity, learning_rate : LearningRate, master_param : MasterParam, float mu, bool use_nesterov, str regularization_method, float regularization_coeff, bool multi_precision, float rescale_grad, float rampup_begin_step} | |||
There was a problem hiding this comment.
Suggested change
| {param : Param, grad : Grad, velocity : Velocity, learning_rate : LearningRate, master_param : MasterParam, float mu, bool use_nesterov, str regularization_method, float regularization_coeff, bool multi_precision, float rescale_grad, float rampup_begin_step} | |
| {param : Param, grad : Grad, velocity : Velocity, learning_rate : LearningRate, master_param : MasterParam} |
op_compat里面只声明必要的映射就可以了，后面的没必要复制粘贴
| args : (Tensor param, Tensor grad, Tensor velocity, Tensor learning_rate, Tensor master_param, Tensor current_step, Tensor nranks, float mu, bool use_nesterov=false, str regularization_method="", float regularization_coeff=0.0f, bool multi_precision=false, float rescale_grad=1.0f, float rampup_begin_step=-1.0f) | ||
| output : Tensor(param_out), Tensor(velocity_out), Tensor(master_param_out), Tensor(grad_out) | ||
| kernel : | ||
| func : dgc_momentum |
There was a problem hiding this comment.
Suggested change
| func : dgc_momentum | |
| func : dgc_momentum | |
| param: [和kernel一致的参数顺序] |
args的参数顺序是可以调整的，有时也是必要的。但是这个时候 kernel和infermeta中就需要指定一个和函数调用所需参数一致的顺序，可以参考 #61293 ，也遇到了类似问题。
There was a problem hiding this comment.
多谢，但我这里好像是参数后面写错了，后面顺序是一致的
xiaoyewww
force-pushed
the
pir/dgc_momentum
branch
from
9c11076
to
d7923a9
Compare
|
@kangguangli 这里ci都过了，麻烦再review一下～ |
|
Sorry to inform you that d7923a9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
xiaoyewww
force-pushed
the
pir/dgc_momentum
branch
from
d7923a9
to
fbea24e
Compare
kangguangli
approved these changes
Apr 7, 2024
zyfncg
approved these changes
Apr 7, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Apr 9, 2024
* feat(pir): reg dgc_momentum * feat(pir): reg dgc_momentum * feat(pir): reg dgc_momentum
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Apr 10, 2024
* feat(pir): reg dgc_momentum * feat(pir): reg dgc_momentum * feat(pir): reg dgc_momentum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Devs
Description
#60436
注册算子dgc_momentum