Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th No.10】Add isposinf / isneginf / isreal API to Paddle - part #63523

Merged
merged 15 commits into from
Apr 29, 2024

Conversation

NKNaN
Copy link
Contributor

@NKNaN NKNaN commented Apr 15, 2024

PR Category

User Experience

PR Types

New features

Description

Add isposinf / isneginf / isreal
RFC:PaddlePaddle/community#876

Copy link

paddle-bot bot commented Apr 15, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

luotao1
luotao1 previously approved these changes Apr 18, 2024
check_variable_and_dtype(
x,
"x",
[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we support data type of bf16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.
bf16 type added.

check_variable_and_dtype(
x,
"x",
[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we support data type of bf16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.
bf16 type added.

@jeff41404
Copy link
Contributor

it seems that isin is not included in this PR, delete it from title or add this API?

@NKNaN NKNaN changed the title 【Hackathon 6th No.10】Add isposinf / isneginf / isreal / isin API to Paddle - part 【Hackathon 6th No.10】Add isposinf / isneginf / isreal API to Paddle - part Apr 19, 2024
@NKNaN
Copy link
Contributor Author

NKNaN commented Apr 19, 2024

it seems that isin is not included in this PR, delete it from title or add this API?

isin will be added in another PR.
Deleted.

@luotao1
Copy link
Contributor

luotao1 commented Apr 24, 2024

@NKNaN CI 再rerun下?

@luotao1 luotao1 added the API label Apr 24, 2024
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit e3bf543 into PaddlePaddle:develop Apr 29, 2024
30 checks passed
runzhech pushed a commit to runzhech/Paddle that referenced this pull request Apr 30, 2024
… part (PaddlePaddle#63523)

* add hack10 part

* update fp16

* update

* fix fp16 test

* update en docs

* add bf16

* update docs

* fix test

* rerun ci

* update fp16

* fix fp16 test

* add bf16

* update docs

* fix test

* rerun ci
runzhech pushed a commit to runzhech/Paddle that referenced this pull request Apr 30, 2024
… part (PaddlePaddle#63523)

* add hack10 part

* update fp16

* update

* fix fp16 test

* update en docs

* add bf16

* update docs

* fix test

* rerun ci

* update fp16

* fix fp16 test

* add bf16

* update docs

* fix test

* rerun ci
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 6, 2024
… part (PaddlePaddle#63523)

* add hack10 part

* update fp16

* update

* fix fp16 test

* update en docs

* add bf16

* update docs

* fix test

* rerun ci

* update fp16

* fix fp16 test

* add bf16

* update docs

* fix test

* rerun ci
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 10, 2024
… part (PaddlePaddle#63523)

* add hack10 part

* update fp16

* update

* fix fp16 test

* update en docs

* add bf16

* update docs

* fix test

* rerun ci

* update fp16

* fix fp16 test

* add bf16

* update docs

* fix test

* rerun ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants