-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon 6th Fundable Projects 3 No.374】fluid operator tdm_sampler #63707
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 请 @luotao1 协调日升也Review一下~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原先Fluid的sampler.h/cc也需要删掉
可能其他文件使用,比如paddle/fluid/distributed/index_dataset/index_sampler.h,其他算子迁移后再删除 |
我看用的地方并不多,可以删掉,然后用到的地方全部改成调用phi下的sampler.h,尽量减少俩套相同代码的存在,减少维护成本 |
不是修改sampler.h就可以,有关联的链接库,phi下的链接库不同 |
这个应该不复杂吧,链库的话只需要链接一个phi target就可以了,如果说等其他算子迁移删除也行,那就必须优先搞一下, 不然如果拖的时间太长后边有人对sampler修改就容易造成逻辑不一致的问题了,因为后边改的人他未必会俩个地方都改 |
好的,那等其他算子迁移修改 |
PR Category
Others
PR Types
Others
Description
Migrate fluid operator tdm_sampler