Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean use for templatedoc decorator #63754

Merged
merged 4 commits into from
Apr 23, 2024
Merged

clean use for templatedoc decorator #63754

merged 4 commits into from
Apr 23, 2024

Conversation

ooooo-create
Copy link
Contributor

PR Category

Others

PR Types

Others

Description

ref #63734
清理无用 templatedoc 装饰器的使用，将 OP 定义中的参数描述添加到现有的 docstring 中,清理后框架不再存在 templatedoc 装饰器的使用
templatedoc 装饰器只会替换其中的 template arguments （支持$替换
@SigureMo

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Apr 22, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 22, 2024
SigureMo
SigureMo reviewed Apr 22, 2024
View reviewed changes
python/paddle/nn/clip.py Outdated Show resolved Hide resolved
python/paddle/nn/clip.py Outdated Show resolved Hide resolved
python/paddle/nn/clip.py Outdated Show resolved Hide resolved
python/paddle/nn/clip.py Outdated Show resolved Hide resolved
python/paddle/nn/clip.py Outdated Show resolved Hide resolved
python/paddle/static/nn/common.py Show resolved Hide resolved
python/paddle/static/nn/common.py Outdated Show resolved Hide resolved
python/paddle/static/nn/common.py Outdated Show resolved Hide resolved
python/paddle/static/nn/common.py Outdated Show resolved Hide resolved
python/paddle/tensor/logic.py Outdated Show resolved Hide resolved
SigureMo
SigureMo reviewed Apr 22, 2024
View reviewed changes
python/paddle/nn/clip.py Outdated Show resolved Hide resolved
SigureMo
SigureMo approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
Copy link
Member

Preview links:

@ooooo-create 之后最好从 reviewer 角度来提供 PR 描述信息，比如这个对 @sunzhongkai588 就是最有用的信息

@ooooo-create
Copy link
Contributor Author

Preview links:

* http://preview-paddle-pr-63754.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/en/api/paddle/allclose_en.html

* http://preview-paddle-pr-63754.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/en/api/paddle/static/nn/nce_en.html

* http://preview-paddle-pr-63754.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/en/api/paddle/static/nn/row_conv_en.html

@ooooo-create 之后最好从 reviewer 角度来提供 PR 描述信息，比如这个对 @sunzhongkai588 就是最有用的信息

好的，学到了~

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Apr 23, 2024
@luotao1 luotao1 self-assigned this Apr 23, 2024
sunzhongkai588
sunzhongkai588 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wanghuancoder
wanghuancoder approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit 19468b5 into PaddlePaddle:develop Apr 23, 2024
28 of 29 checks passed
@SigureMo SigureMo mentioned this pull request Apr 23, 2024
Merged
@ooooo-create ooooo-create deleted the clean/templatedoc_part1 branch April 23, 2024 13:17
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 24, 2024
@ooooo-create @co63oc
clean use for templatedoc decorator (PaddlePaddle#63754)
6cf4829
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 25, 2024
@ooooo-create @co63oc
clean use for templatedoc decorator (PaddlePaddle#63754)
af6dc1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@SigureMo SigureMo SigureMo approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

@sunzhongkai588 sunzhongkai588

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ooooo-create @SigureMo @wanghuancoder @sunzhongkai588 @luotao1