Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Fix PIR Unittest No.428】Deprecate test_block_rename_var ut #64078

Merged

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented May 7, 2024

PR Category

Execute Infrastructure

PR Types

Deprecations

Description

test_block_rename_var.py#47097 引入的用于测试老 IR Block._rename_var 的,PIR 无需测试,该单测直接弃用

PCard-66972

Copy link

paddle-bot bot commented May 7, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -15,7 +15,6 @@

STATIC_MODE_TESTING_LIST = [
'test_affine_channel_op',
'test_block_rename_var',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接从 STATIC_MODE_TESTING_LIST 移除,手动加 enable_static(),这样将来直接清理掉 test/deprecated/legacy_test/test_block_rename_var_deprecated.py 这个文件就好了,不用再改这个列表

@SigureMo SigureMo changed the title 【Fix PIR Unittest No.125、147、481】Deprecate test_block_rename_var ut 【Fix PIR Unittest No.428】Deprecate test_block_rename_var ut May 7, 2024
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit df85e2d into PaddlePaddle:develop May 8, 2024
31 checks passed
@SigureMo SigureMo deleted the pir/deprecate-test-block-rename-var branch May 8, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants