Refine CUDA profiler and delete the test file. #6715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Dec 19, 2017
python/paddle/v2/fluid/profiler.py
Outdated
| "enableonstart 0", | ||
| "conckerneltrace", | ||
| "active_warps", | ||
| "active_warps", |
There was a problem hiding this comment.
Why "active_warps" appeared two times, and "cacheconfigrequested" appeared three times?
| config_file = 'nvprof_config_file' | ||
| with open(config_file, 'wb') as fp: | ||
| fp.writelines(["%s\n" % item for item in config]) | ||
| core.nvprof_init(output_file, output_mode, config_file) |
There was a problem hiding this comment.
Should we check whether output_file exists? If output_file has already existed, does this profile result to rewrite the original content of the output_file?
There was a problem hiding this comment.
I do not change the code, all you mentioned can be done by the users when using this interface. Thanks!
|
Too much options will affect the speed of the program. |
|
@chengduoZH Thanks for your careful review. I resume the config after a verification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6714
Fix #6033